New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793282 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security

Blocking:
issue v8:6876



Sign in to add a comment

DCHECK failure in size + CallSize(target, offset, cond, rs, rt, bd) == SizeOfCodeGeneratedSince(&s

Project Member Reported by ClusterFuzz, Dec 8 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4633495124312064

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  size + CallSize(target, offset, cond, rs, rt, bd) == SizeOfCodeGeneratedSince(&s
  V8_Dcheck
  v8::internal::TurboAssembler::Call
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=49947:49948

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4633495124312064

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 8 2017

Labels: Pri-1
Components: -Blink>JavaScript Blink>JavaScript>WebAssembly
Owner: mtrofin@chromium.org
Assigning based on regressing CL. PTAL?
Labels: Security_Impact-Head
Status: Started (was: Untriaged)
Not sure this is a security issue, since the --future flag needs to be explicitly passed.
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 9 2017

Labels: M-64
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 9 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 10 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
Lowering priority - this happens under the --future flag only. Also removing release block flag, same reason
Blocking: v8:6876
I think it makes sense to block the tracking bug for the off-heap work  with the failures found. That way, nothing falls through the cracks.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 11 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable ReleaseBlock-NA
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a9d9001810aef2b3ad9487b4e9cb5ae766381abc

commit a9d9001810aef2b3ad9487b4e9cb5ae766381abc
Author: Mircea Trofin <mtrofin@chromium.org>
Date: Tue Dec 12 15:02:23 2017

[wasm] Fix up mips & WasmCodeManager

Corrected mips code generation for WASM_CALL and JS_TO_WASM_CALL.

The logic for fetching raw call sites needed changing, too, in light
of mips' 2-instruction calls, where using target_address_address is
incorrect. The CL adds platform-specific accessors.

Bug:  chromium:793292   chromium:793282 
Change-Id: I879ea6bffdad60791d88a6f5ea15087cdcd3f2e9
Reviewed-on: https://chromium-review.googlesource.com/818460
Reviewed-by: Ben Titzer <titzer@chromium.org>
Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@mips.com>
Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50037}
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/compiler/mips/code-generator-mips.cc
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/mips/assembler-mips-inl.h
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/mips64/assembler-mips64-inl.h
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/wasm/wasm-code-manager.cc
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/wasm/wasm-code-manager.h
[modify] https://crrev.com/a9d9001810aef2b3ad9487b4e9cb5ae766381abc/src/wasm/wasm-serialization.cc

Status: Fixed (was: Started)
Project Member

Comment 15 by ClusterFuzz, Dec 13 2017

ClusterFuzz has detected this issue as fixed in range 50036:50037.

Detailed report: https://clusterfuzz.com/testcase?key=4633495124312064

Fuzzer: ochang_js_fuzzer
Job Type: linux_asan_d8_v8_mipsel_dbg
Platform Id: linux

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  size + CallSize(target, offset, cond, rs, rt, bd) == SizeOfCodeGeneratedSince(&s
  V8_Dcheck
  v8::internal::TurboAssembler::Call
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=49947:49948
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_d8_v8_mipsel_dbg&range=50036:50037

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4633495124312064

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 16 by ClusterFuzz, Dec 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4633495124312064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 13 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 18 by sheriffbot@chromium.org, Dec 15 2017

Labels: Merge-Request-64
Project Member

Comment 19 by sheriffbot@chromium.org, Dec 15 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-64 -Merge-Review-64 M-65
Regression and fix range are both in 65.
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 22 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta Security_Impact-Stable

Sign in to add a comment