New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793272 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Slight delay is seen while loading the first entry in PDF bookmarks list.

Reported by avsha...@etouch.net, Dec 8 2017

Issue description

Chrome Version : 65.0.3288.0 (Official Build) 25b7dd1729eebe969f4bfd358babec31b96589ca-refs/heads/master@{#522666} 64-bit
OS : Mac(10.12.6), Windows(7,8,10), Linux(14.04 LTS)

Test URL 1 : https://collegereadiness.collegeboard.org/pdf/sat-practice-test-1.pdf
Test URL 2 : http://cb.vu/unixtoolbox.pdf 

What steps will reproduce the problem?
1. Launch chrome and navigate to test URL 1 (kindly wait until PDF loads completely).
2. Click on ‘Bookmarks’ button seen on the PDF toolbar and observe the first entry in the bookmarks list.

Actual Result : Slight delay is seen while loading the first entry in PDF bookmarks list. 

Expected Result : Entries under PDF bookmarks list should load without any delay.

This is a regression issue broken in ‘M-65’ and using the per-revision bisect providing the bisect results,
Good build : 65.0.3285.0 (Revision : 521572)
Bad build : 65.0.3286.0 (Revision : 521956)

You are probably looking for a change made after 521934 (known good), but no later than 521935 (first known bad).

CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/8b88cf6148049b087b41a381ef09189599168e54..20c3c4178f0a1f0847fff1df62b3704fb690108f

Suspect : https://chromium.googlesource.com/chromium/src/+/20c3c4178f0a1f0847fff1df62b3704fb690108f

@wangxianzhu : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Note : 
1. Issue is not observed on Mac Touch bar(10.13.2)
2. Above issue can be reproduced on any PDF page that has ‘Bookmarks’ list.
 
Actual_Result.mov
4.7 MB Download
Expected_Result.mov
3.8 MB Download
Labels: ReleaseBlock-Stable
Adding release blocker for this issue.Please undo if not the case.
Cc: trchen@chromium.org schenney@chromium.org
It seems that the new InnerBorderRadiusClip node for the iframe causes incorrect visual rect during the animation.
Scratch #c2. There is no iframe. This is a bug caused by incorrect InnerBorderRadius node relationship with OverflowClip introduced in the CL.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94b89f4fe30c693692988e3360acf3c8952c532e

commit 94b89f4fe30c693692988e3360acf3c8952c532e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sun Dec 10 06:24:43 2017

[SPv175/PE] SetLayerState for AncestorClippingMaskLayer and ChildClippingMaskLayer

Code change in RarePaintData::ContentsProperties() and PaintLayerPainter::
NeedsToClip() also fix bugs of SPv1 by the way:
-  crbug.com/793272  (incorrect property hierarchy about InnerBordorRadiusClip)
- a bug causing the revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/817372
  (not landed because this CL will fix the bug).
  Added a test case (compositing/overflow/border-radius-above-composited-subframe.html)
  for the bug.

Bug:  790548 , 793272 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I514d9b1ae20fe7ebfe0c1712c67a9dae8b4a11d8
Reviewed-on: https://chromium-review.googlesource.com/798511
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523020}
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe-expected.txt
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-above-composited-subframe.html
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-above-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-above-composited-subframe-expected.txt
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/virtual/spv175/compositing/overflow/border-radius-composited-subframe-expected.png
[add] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/LayoutTests/virtual/spv175/compositing/overflow/border-radius-on-parent-composited-grandchild-expected.png
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/BlockPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/BoxPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/ClipRect.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintLayerPainter.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/PaintPhase.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/RarePaintData.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/RarePaintData.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.h
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/CompositingLayerPropertyUpdater.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/core/paint/compositing/GraphicsLayerUpdater.cpp
[modify] https://crrev.com/94b89f4fe30c693692988e3360acf3c8952c532e/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment