Issue 793267 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	peconn@chromium.org
Closed:	Jan 2018
Components:	Internals>Media>UI
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Bug

InfoBars are not dismissed while entering PiP

Project Member Reported by peconn@chromium.org, Dec 8 2017

Issue description

An InfoBar in PiP mode takes up most of the screen, so we should dismiss InfoBars when entering PiP.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbfd53a1c871c54b610221c14fe2d5bd9771ad99

commit cbfd53a1c871c54b610221c14fe2d5bd9771ad99
Author: Peter E Conn <peconn@chromium.org>
Date: Wed Jan 03 14:37:15 2018

📺 Dismiss InfoBars before entering PiP.

Bug:  793267 
Change-Id: Ia3bfa5852b2d00031a8467e75b4ee9f686397660
Reviewed-on: https://chromium-review.googlesource.com/816869
Reviewed-by: Ted Choc (back but slow, ping me) <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526686}
[modify] https://crrev.com/cbfd53a1c871c54b610221c14fe2d5bd9771ad99/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/cbfd53a1c871c54b610221c14fe2d5bd9771ad99/chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java
[modify] https://crrev.com/cbfd53a1c871c54b610221c14fe2d5bd9771ad99/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPictureController.java

Comment 2 by peconn@chromium.org, Jan 3 2018

Status: Fixed (was: Started)

►

Issue 793267 link

Issue metadata

InfoBars are not dismissed while entering PiP

Issue description

Comment 1 by bugdroid1@chromium.org, Jan 3 2018

Comment 1 Deleted

Comment 2 by peconn@chromium.org, Jan 3 2018

Comment 2 Deleted

Sign in to add a comment