New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793266 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Selected Image should be seen in print preview instead of all images in Camera App

Project Member Reported by mmanchala@chromium.org, Dec 8 2017

Issue description

Chrome Version: 64.0.3282.14/10176.7.0 dev channel Kip,Reks and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Launch Camera App -> Click on 'Take a picture' -> Take multiple picures
(3)Now Click on 'Go to Gallery' ->select a picture -> Click on 'Print' -> observe all images are seen in print preview (Please refer video)

Expected: Selected Image should be seen in print preview
Actual: Instead all images are seen in print preview

Note : 
1. In Gallery -> Select any one picture -> click on 'Delete' option -> observe only one pic is deleted 
2. In Gallery -> Select any one picture -> click on 'Save to disk' option -> observe only one picture is saved in Files App (Please refer 'Expected_Behavior'  video)

This is Non-Regression Issue seen from M-56

@yuli :Please confirm the Issue

 
Actual_Print.webm
5.5 MB View Download
Expected_Behavior.webm
1.1 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/camera/+/3e1ed40f7ce162b36817dec5333d8288bf4ce610

commit 3e1ed40f7ce162b36817dec5333d8288bf4ce610
Author: Yuli Huang <yuli@chromium.org>
Date: Sat Mar 10 07:45:36 2018

Show only selected items in album's print-preview.

BUG= chromium:793266 
TEST=Tested manually on elm.

Change-Id: Ib72ca2cda05192f94dc854820712b17f60968bc9
Reviewed-on: https://chromium-review.googlesource.com/956827
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/3e1ed40f7ce162b36817dec5333d8288bf4ce610/src/css/main.css

Comment 2 by y...@chromium.org, Mar 12 2018

Status: Fixed (was: Assigned)
The fix is that showing only the selected items (maybe one or multiple selected) for print-preview in the album mode, similar to how delete/save buttons only perform on the selected items. Please note that users need to double click on one item in the album to enter browsing mode and print-preview a single large image.

Please verify the fix on the next Camera app canary once it's released.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e1ed40f7ce162b36817dec5333d8288bf4ce610

commit 3e1ed40f7ce162b36817dec5333d8288bf4ce610
Author: Yuli Huang <yuli@chromium.org>
Date: Sat Mar 10 07:45:36 2018

Show only selected items in album's print-preview.

BUG= chromium:793266 
TEST=Tested manually on elm.

Change-Id: Ib72ca2cda05192f94dc854820712b17f60968bc9
Reviewed-on: https://chromium-review.googlesource.com/956827
Reviewed-by: Sheng-hao Tsao <shenghao@google.com>
Tested-by: yuli <yuli@chromium.org>

[modify] https://crrev.com/3e1ed40f7ce162b36817dec5333d8288bf4ce610/src/css/main.css

Sign in to add a comment