New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793262 link

Starred by 4 users
Status: Fixed
Owner:
alemate@chromium.org
Closed: Dec 2017
Cc:
ajha@chromium.org
█ brajkumar@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Next' button is seen enabled even if no network is connected in OOBE screen

Project Member Reported by mmanchala@chromium.org, Dec 8 2017 
Chrome Version: 64.0.3282.14/10176.7.0 dev channel Kip,Reks and Daisy
OS: Chrome

What steps will reproduce the problem?
1)Recover build -> In OOBE screen click on 'Let's go' which navigates to 'Connect to network' screen
2)Now connect to Wi-Fi Network -> Navigates to EULA screen -> clic 'Back' buttonscroll down and click on 'Proxy settings' option
3)Now 'Connect to network' screen -> click on Uber Tray and select select 'Network' option and click on 'Network settings' icon -> 'Network settings' window is seen -> Click on 'DISCONNECT' and close that Window
4)Now observe 'Next' button is seen enabled and on clicking nothing happens (Please refer Video and Screenshot)

Expected: 'Next' button should be disabled if no network is connected
Actual: Instead 'Next' button is seen enabled

This is Regression Issue as same is working fine in 62.0.3202.97/9901.77.0 stable-channel Reks

@alemate : Please confirm the Issue
Actual_NextButtonIsEnabled.mp4
17.9 MB Download
Actual_NextButtonIsEnabled.jpg
409 KB View Download

Comment 1 by mmanchala@chromium.org, Dec 8 2017 

Attaching Expected video and Screenshot for reference
Expected_NextButtonISDisabled.mp4
17.4 MB Download
Expected_NextButtonISDisabled.jpg
362 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0b408d6d09a69f9ef3e618530fe87540ec00fc7

commit d0b408d6d09a69f9ef3e618530fe87540ec00fc7
Author: Alexander Alekseev <alemate@chromium.org>
Date: Fri Dec 15 02:06:33 2017

Chrome OS Network UI: forget selected network when it disappears from the list.

This CL fixes error message:

    Error in response to networkingPrivate.getNetworks: TypeError: Cannot read
    property 'GUID' of null", source: chrome://oobe/oobe (0)

and clears default network if it disappears from the list of networks.

Bug:  793262 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia72e650b73202de56b8ec842dbcee81f65366793
Reviewed-on: https://chromium-review.googlesource.com/822171
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524287}
[modify] https://crrev.com/d0b408d6d09a69f9ef3e618530fe87540ec00fc7/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/d0b408d6d09a69f9ef3e618530fe87540ec00fc7/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/d0b408d6d09a69f9ef3e618530fe87540ec00fc7/ui/webui/resources/cr_elements/chromeos/network/compiled_resources2.gyp
[modify] https://crrev.com/d0b408d6d09a69f9ef3e618530fe87540ec00fc7/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js

Comment 3 by alemate@chromium.org, Dec 15 2017

Labels: Merge-Request-64
Status: Fixed (was: Assigned)

Comment 4 by kbleicher@chromium.org, Dec 15 2017

Labels: -Merge-Request-64 Merge-Approved-64
Approving merge to M64 Chrome OS.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11eb1e1394e1d2ae0ed9615ff936c0684f5efa33

commit 11eb1e1394e1d2ae0ed9615ff936c0684f5efa33
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Dec 20 02:46:15 2017

Chrome OS Network UI: forget selected network when it disappears from the list.

This CL fixes error message:

    Error in response to networkingPrivate.getNetworks: TypeError: Cannot read
    property 'GUID' of null", source: chrome://oobe/oobe (0)

and clears default network if it disappears from the list of networks.

TBR=alemate@chromium.org

(cherry picked from commit d0b408d6d09a69f9ef3e618530fe87540ec00fc7)

Bug:  793262 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia72e650b73202de56b8ec842dbcee81f65366793
Reviewed-on: https://chromium-review.googlesource.com/822171
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524287}
Reviewed-on: https://chromium-review.googlesource.com/835708
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#304}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/11eb1e1394e1d2ae0ed9615ff936c0684f5efa33/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/11eb1e1394e1d2ae0ed9615ff936c0684f5efa33/chrome/browser/resources/chromeos/network_ui/network_ui.js
[modify] https://crrev.com/11eb1e1394e1d2ae0ed9615ff936c0684f5efa33/ui/webui/resources/cr_elements/chromeos/network/compiled_resources2.gyp
[modify] https://crrev.com/11eb1e1394e1d2ae0ed9615ff936c0684f5efa33/ui/webui/resources/cr_elements/chromeos/network/cr_network_select.js
►

Sign in to add a comment