Issue metadata
Sign in to add a comment
|
Regression : Able to see entered PIN in 'ENTER SIM PIN' Dialog box |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3282.14/10176.7.0 dev channel Kip,Reks and Daisy OS: Chrome What steps will reproduce the problem? 1)Sign into User ->Insert Mobile Dongle and ensure it is connected (2)Now go to chrome://settings page -> At Internet Connection click on Cellular connection -> Navigates to Cellular connected page (3)Now Enable 'Enable SIM Card locking(require PIN to use Mobile data) option -> 'ENTER SIM PIN' Dialog box is seen -> enter pin and observe PIN is not hidden i.e. able to see PIN(Please refer Video and Screenshot) Expected: PIN should be hidden in 'ENTER SIM PIN' Dialog box Actual: Instead able to see entered PIN This is Regression issue as same is working fine in old settings page i.e. unable to see entered PIN(PIN is in hidden mode) @stevenjb : Please confirm the Issue
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfa3559f8e7eedcf281fd40f5ca97a0932582cb0 commit bfa3559f8e7eedcf281fd40f5ca97a0932582cb0 Author: Steven Bennetts <stevenjb@chromium.org> Date: Sat Dec 09 02:15:51 2017 Network: SIM unlock: Use network-config-input + password This CL uses network-config-input in the SIM dialog. This updates the style to match other config dialogs and includes a 'password' option to hide the input and show a toggle button to allow showing it. Bug: 793260 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I092946f0b7a00c8963164eb3cdc4dd2e6a69a2c0 Reviewed-on: https://chromium-review.googlesource.com/817992 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#522962} [modify] https://crrev.com/bfa3559f8e7eedcf281fd40f5ca97a0932582cb0/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
,
Dec 9 2017
,
Dec 10 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14b5758f2af34ee57d50214051777492a48f5313 commit 14b5758f2af34ee57d50214051777492a48f5313 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Dec 11 19:57:49 2017 Network: SIM unlock: Use network-config-input + password This CL uses network-config-input in the SIM dialog. This updates the style to match other config dialogs and includes a 'password' option to hide the input and show a toggle button to allow showing it. TBR=stevenjb@chromium.org (cherry picked from commit bfa3559f8e7eedcf281fd40f5ca97a0932582cb0) Bug: 793260 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I092946f0b7a00c8963164eb3cdc4dd2e6a69a2c0 Reviewed-on: https://chromium-review.googlesource.com/817992 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522962} Reviewed-on: https://chromium-review.googlesource.com/820415 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#144} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/14b5758f2af34ee57d50214051777492a48f5313/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
,
Oct 4
Checked and Issue is working fine on latest M-70 70.0.3538.41/11021.37.0 beta-channel Candy Thanks..!! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Dec 8 2017