New issue
Advanced search Search tips

Issue 793243 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

telemetry_Benchmarks stop working since R64-10035.0.0

Project Member Reported by cywang@chromium.org, Dec 8 2017

Issue description

Most of the wprgo files are not packaged in the test image, all wprgo related benchmarks are dead now.
 
jetstream.png
58.9 KB View Download
kraken.png
61.2 KB View Download
The root cause is mainly from the missing of escape character for rsync option over ssh command:

Before the failure: the command is 

ssh 100.115.219.136 rsync --rsh=\"/usr/bin/ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o BatchMode=yes -o ConnectTimeout=30 -o ServerAliveInterval=900 -o ServerAliveCountMax=3 -o ConnectionAttempts=4 -o Protocol=2 -x -a -l root\" -L --timeout=1800 -az --no-o --no-g /home/chromeos-test/images/veyron_minnie-release/R63-10032.71.0/telemetry_src/src/tools/perf/page_sets/data/jetstream_000.wprgo ch


and now it failed without the escape character:

ssh 100.115.219.136 rsync -L  --timeout=1800 -e '/usr/bin/ssh -a -x  -o Protocol=2 -o StrictHostKeyChe
cking=no -o UserKnownHostsFile=/dev/null -o BatchMode=yes -o ConnectTimeout=30 -o ServerAliveInterval=900 -o ServerAliveCountMax=3 -o ConnectionAttempts=4 -l root -p 22' -az --no-o --no-g  /home/chromeos-test/images/veyron_minnie-release/R65-10196.0.0/telemetry_src/src/tools/perf/page_sets/data/jetstream_000.wprgo chromeos4-row9-rack11-host17:/usr/local/telemetry/src/tools/perf/page_sets/data/jetstream_000.wprgo

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fd8eb249926efb6571dd31a24f20c988a874d227

commit fd8eb249926efb6571dd31a24f20c988a874d227
Author: Chung-yih Wang <cywang@google.com>
Date: Mon Dec 11 20:47:47 2017

telemetry_runner: Add quotes for rsync command

The rsync option over ssh was eaten by the ssh command which failed
the rsync command for telemetry_Benchmark tests to copy the wprgo
files to DUT via devserver. This patch fixes it with adding the
quotes for the rsync command over ssh.

BUG= chromium:793243 
TEST=manual test with command with escape character added:

ssh DEVSERVER_IP "rsync -L --delete --timeout=1800
--rsh='/usr/bin/ssh -a -x -o
ControlPath=/tmp/_autotmp_qk913Mssh-master/socket -o Protocol=2 -o
StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o
BatchMode=yes -o ConnectTimeout=30 -o ServerAliveInterval=900 -o
ServerAliveCountMax=3 -o ConnectionAttempts=4 -l root -p 22' -az --no-o
--no-g
PATH_OF_jetstream_000.wprgo
\"DUT_IP:/usr/local/telemetry/src/tools/perf/page_sets/data/jetstream_000.wprgo\""

Change-Id: Ie61516d5ef4cd54a8fa70e9cefea73f7ce1b9e03
Signed-off-by: Chung-yih Wang <cywang@google.com>
Reviewed-on: https://chromium-review.googlesource.com/818590
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Ben Cheng <bccheng@chromium.org>

[modify] https://crrev.com/fd8eb249926efb6571dd31a24f20c988a874d227/server/cros/telemetry_runner.py

Sign in to add a comment