New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793214 link

Starred by 2 users
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Dec 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Dev tools window on page doesnot get reloaded after killing page.

Reported by db...@etouch.net, Dec 8 2017 
Chrome Version: 65.0.3288.0 Revision 25b7dd1729eebe969f4bfd358babec31b96589ca-refs/heads/master@{#522666}(32/64 bit)
OS: Windows(7,8,10), Mac(10.12.6, 10.13.2), Liunx(14.1LTS)

What steps will reproduce the problem?
(1) Launch chrome, open NTP and open dev tools window. 
(2) Type chrome://kill in the NTP to open kill page, then reload page  
(3) Observe dev tools window.

Actual: Dev tools window doesnot get reloaded after killing page.

Expected: Dev tools window should get reloaded after killing page.

This is a regression issue. broken in 'M65', will soon update the other info:

Comment 1 by db...@etouch.net, Dec 8 2017

Labels: hasbisect-per-revision
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 64.0.3275.0
Bad Build: 64.0.3276.0

You are probably looking for a change made after 518527 (known good), but no later than 518528 (first known bad).

CHANGELOG URL:

https://chromium.googlesource.com/chromium/src/+log/675baeddc640f35516f2b57bd81521c659a34306..450e5167b5418bff2ac167d9dff8d2d7314ed268

Suspect: https://chromium.googlesource.com/chromium/src/+/450e5167b5418bff2ac167d9dff8d2d7314ed268
Actual_Kill.mp4
534 KB View Download
Expected_Kill.mp4
433 KB View Download

Comment 2 by rbasuvula@chromium.org, Dec 8 2017

Labels: ReleaseBlock-Stable
Adding release blocker for this issue.Please undo if not the case.

Thank You!
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/352d3a4dd9cc13e55a7d6145a7a1400466fd23ec

commit 352d3a4dd9cc13e55a7d6145a7a1400466fd23ec
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 18 23:45:19 2017

[DevTools] Fix DevTools reattaching after crash

Bug:  793214 
Change-Id: I0e2899acdc9fa890552455968c1dc00389cd224c
Reviewed-on: https://chromium-review.googlesource.com/833170
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524858}
[modify] https://crrev.com/352d3a4dd9cc13e55a7d6145a7a1400466fd23ec/content/browser/devtools/render_frame_devtools_agent_host.cc

Comment 4 by db...@etouch.net, Dec 19 2017

Labels: TE-Verified-M65 TE-Verified-65.0.3299.0
Just to update:

Above issue is fixed on latest canary build #65.0.3299.0

Thank you.
Actual_Fix.mp4
635 KB View Download

Comment 5 by dgozman@chromium.org, Dec 20 2017

Labels: -M-65 M-64 Merge-Request-64
Status: Fixed (was: Assigned)
Requesting merge to 64.
Project Member

Comment 6 by sheriffbot@chromium.org, Dec 20 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by abdulsyed@google.com, Dec 21 2017

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge to M64. Branch:3282
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 27 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65652a36fb2de8ff6edc772d367ad2981062ee2b

commit 65652a36fb2de8ff6edc772d367ad2981062ee2b
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Dec 27 18:03:49 2017

[DevTools] Fix DevTools reattaching after crash

TBR=dgozman@chromium.org

(cherry picked from commit 352d3a4dd9cc13e55a7d6145a7a1400466fd23ec)

Bug:  793214 
Change-Id: I0e2899acdc9fa890552455968c1dc00389cd224c
Reviewed-on: https://chromium-review.googlesource.com/833170
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524858}
Reviewed-on: https://chromium-review.googlesource.com/844894
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#362}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/65652a36fb2de8ff6edc772d367ad2981062ee2b/content/browser/devtools/render_frame_devtools_agent_host.cc

Comment 9 by db...@etouch.net, Jan 3 2018

Labels: TE-Verified-64.0.3282.71 TE-Verified-M64
Update: 
Above issue is fixed on latest Beta build #64.0.3282.71 using Windows(7,8,10), Mac(10.12.6, 10.13.2)and Liunx(14.1LTS)

Thank you.
Fix_Actual.mp4
386 KB View Download
►

Sign in to add a comment