Chrome OS notification uses fixed font size |
||
Issue descriptionIn Chrome OS, notification (NotificationViewMD) and notification center (MessageCenterView) uses fixed font sizes for many places. This is not the right way of setting font size because users can't change the system font size (e.g. for a11y reasons) of these UIs. In NotificationViewMD, it is important that ARC notification and NotificationViewMD uses the same base font size because of consistency. So if we support base font size change, we should sync the size with ARC, which can be a large change. On the other hand, ash/message_center does not have such reasoning, so it's better to remove GetFontListForSizeAndWeight.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6248fb5dd6880f0801ccabf901a8fd0ee16116ae commit 6248fb5dd6880f0801ccabf901a8fd0ee16116ae Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Dec 13 05:24:12 2017 Use relative font size in ash notification center. Notification center used fixed font sizes for UI labels. This is not the right way of settings font size. This CL - removes ash::message_center_style::GetFontListForSizeAndWeight(). - replaces all fixed font sizes with delta. TEST=manual - compared screenshots and verified it cause no visual change on actual device (chell) BUG= 793207 Change-Id: Ia2c50965e6a132520d63921252e78a76a644734f Reviewed-on: https://chromium-review.googlesource.com/817456 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523696} [modify] https://crrev.com/6248fb5dd6880f0801ccabf901a8fd0ee16116ae/ash/BUILD.gn [modify] https://crrev.com/6248fb5dd6880f0801ccabf901a8fd0ee16116ae/ash/message_center/message_center_button_bar.cc [delete] https://crrev.com/06f3193494518764f0a6300b3407af051039e266/ash/message_center/message_center_style.cc [modify] https://crrev.com/6248fb5dd6880f0801ccabf901a8fd0ee16116ae/ash/message_center/message_center_style.h [modify] https://crrev.com/6248fb5dd6880f0801ccabf901a8fd0ee16116ae/ash/message_center/message_center_view.cc [modify] https://crrev.com/6248fb5dd6880f0801ccabf901a8fd0ee16116ae/ash/message_center/notifier_settings_view.cc
,
Oct 22
|
||
►
Sign in to add a comment |
||
Comment 1 by tetsui@chromium.org
, Dec 12 2017