New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793181 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Milo.BuildInfo result does not contain a ended or last updated time

Project Member Reported by jinjingl@chromium.org, Dec 8 2017

Issue description

An example here:
https://luci-milo.appspot.com/rpcexplorer/services/milo.BuildInfo/Get?request={%20%20%20%20%22buildbucket%22:%20{%20%20%20%20%20%20%20%20%22id%22:%20%228960871244673031312%22%20%20%20%20}}

It only has "started": "2017-12-07T10:58:07.049546683Z",

But the corresponding Milo page does have ended time.
https://luci-milo.appspot.com/buildbot/chromeos/asuka-release/1650 

I guess I have a bigger question, can BuildInfo return the same amount of information that the Milo pages have? 




 

Comment 1 by no...@chromium.org, Dec 8 2017

Cc: no...@chromium.org
Components: -Infra>Platform>Milo>LUCI Infra>Platform>Milo>Buildbot
Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)
(hinoka is more of an owner of BuildInfo than I am)

Comment 2 by efoo@chromium.org, Dec 8 2017

Labels: LUCI-M0-Backlog
Components: Infra>Platform>Recipes
The problem is the annotations isn't outputting end time:
https://luci-milo.appspot.com/raw/build/logs.chromium.org/chromeos/bb/chromiumos.tryserver/release/18095/+/recipes/annotations
So there's a problem on the recipe/client side too.

nodir@: Since we have a buildbot emulation layer, do you think we can recommend ChromeOS to use the GetBuildbotBuildJSON endpoint instead?
https://luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildJSON?request={%20%20%20%20%22master%22:%20%22chromiumos.tryserver%22,%20%20%20%20%22builder%22:%20%22release%22,%20%20%20%20%22buildNum%22:%2018095}

We originally asked ChromeOS to use BuildInfo because we thought that would be the LUCI endpoint going forward, but the design has shifted since then.
But GetBuildbotBuildJSON does not work for swarming builds? We are looking for an API that has through information for both swarming and buildbot builds :-) 

Comment 5 by no...@chromium.org, Dec 12 2017

i am not sure how emulation in GetBuildbotBuildJSON will help in this case.

workaround: use buildbucket API (don't you already use it?)
https://apis-explorer.appspot.com/apis-explorer/?base=https://cr-buildbucket.appspot.com/_ah/api#p/buildbucket/v1/buildbucket.get?id=8960871244673031312&_h=1&
has completed_ts

Thanks Nodir, I was using Buildbucket API for more high level summary such as how many slave builds passed for one master build, and Milo.BuildInfo for more details stage and timing. It is indeed a good idea to start using Buildbucket for build overall start/finish time as well.

With that said, the detailed stage information is still important, and please let me know if Milo.BuildInfo is the right way to go down :-) 

Thanks a lot Nodir and Ryan! 

Comment 7 by no...@chromium.org, Dec 12 2017

BuildInfo's future is at least very unclear, but we don't have anything better to offer at this point. Ideally we provide a proper API that works for GE and GE does not use BuildInfo (that sometimes works and sometimes does not).

I've created https://docs.google.com/document/d/1ZV3RbxR23R0NkVeKofQumdluPlz0HCBFa6k0a5ok0T4/edit#
to collect GE's API requirements

Comment 8 by efoo@chromium.org, Jan 30 2018

Labels: LUCI-Backlog

Comment 9 by efoo@chromium.org, Jan 30 2018

Labels: -LUCI-M0-Backlog
Cc: iannu...@google.com

Sign in to add a comment