New issue
Advanced search Search tips

Issue 793176 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

NetworkQualityEstimatorTest.RecordAccuracy test flakes on Fuchsia

Project Member Reported by w...@chromium.org, Dec 8 2017

Issue description

Test frequently flakes with output:

[ RUN      ] NetworkQualityEstimatorTest.RecordAccuracy
../../base/test/histogram_tester.cc:177: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "NQE.Accuracy.DownstreamThroughputKbps.EstimatedObservedDiff.Positive.1.1260_2540" does not have the right number of samples (1) in the expected bucket (1). It has (0).
../../base/test/histogram_tester.cc:192: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "NQE.Accuracy.DownstreamThroughputKbps.EstimatedObservedDiff.Positive.1.1260_2540" does not have the right total number of samples (1). It has (0).
../../base/test/histogram_tester.cc:177: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "NQE.Accuracy.EffectiveConnectionType.EstimatedObservedDiff.Positive.1.3G" does not have the right number of samples (1) in the expected bucket (1). It has (0).
../../base/test/histogram_tester.cc:192: Failure
      Expected: expected_count
      Which is: 1
To be equal to: actual_count
      Which is: 0
Histogram "NQE.Accuracy.EffectiveConnectionType.EstimatedObservedDiff.Positive.1.3G" does not have the right total number of samples (1). It has (0).
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "NQE.Accuracy.HttpRTT.EstimatedObservedDiff.Negative.1.300_620" does not exist.
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "NQE.Accuracy.TransportRTT.EstimatedObservedDiff.Negative.1.300_620" does not exist.
../../base/test/histogram_tester.cc:39: Failure
Expected: (nullptr) != (histogram), actual: 8-byte object <00-00 00-00 00-00 00-00> vs NULL
Histogram "NQE.ExternalEstimateProvider.RTT.Accuracy.EstimatedObservedDiff.Negative.1.300_620" does not exist.
[  FAILED  ] NetworkQualityEstimatorTest.RecordAccuracy (8010 ms)
 
Components: -Internals>Network Internals>Network>DataUse

Comment 2 by w...@chromium.org, Jan 26 2018

Labels: -M-65 M-66
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a741314eb2e0a75f00f4162bfb0ca3ee7a1da1c5

commit a741314eb2e0a75f00f4162bfb0ca3ee7a1da1c5
Author: Scott Graham <scottmg@chromium.org>
Date: Tue Feb 06 21:01:53 2018

fuchsia: Disable two flakes, one in base_unittests one in net_unittests

NetworkQualityEstimatorTest.RecordAccuracy: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/13666

AddressSpaceRandomizationTest.Random: https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20ARM64/builds/5325

Bug:  793176 ,  809660 
Change-Id: Ie4c01c4aa7889cc71ed7cec91b8c2f5d358f865c
Reviewed-on: https://chromium-review.googlesource.com/905203
Commit-Queue: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534790}
[modify] https://crrev.com/a741314eb2e0a75f00f4162bfb0ca3ee7a1da1c5/testing/buildbot/filters/fuchsia.base_unittests.filter
[modify] https://crrev.com/a741314eb2e0a75f00f4162bfb0ca3ee7a1da1c5/testing/buildbot/filters/fuchsia.net_unittests.filter

Comment 4 by w...@chromium.org, Mar 6 2018

Labels: -M-66 M-67

Comment 5 by bengr@chromium.org, May 2 2018

Is this fixed?

Comment 6 by w...@chromium.org, May 3 2018

Labels: -M-67 M-68
Owner: ----
Status: Available (was: Assigned)
No, just filtered on Fuchsia for the time being.
Cc: tbansal@chromium.org
Is there someone that can own this if it's a P2? Should the milestone be updated?
Owner: tbansal@chromium.org
Status: Assigned (was: Available)
tbansal, can you take a quick look at this?
Refreshed during triage
Refreshed during triage
Refreshed during triage.
Status: Fixed (was: Assigned)
Since the underlying problem is fixed, I am closing this one for now. We should revisit this once we have specific use case for NQE on Fuchsia.

Sign in to add a comment