New issue
Advanced search Search tips

Issue 793167 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] Need more specific error message for third-party auth error

Project Member Reported by yuweih@chromium.org, Dec 8 2017

Issue description

Currently when connecting to a corp host, a snack bar will pop up with this message: "[ThirdPartyAuth] Unable to authenticate with HOSTNAME".

This should be changed to something more specific, e.g. "Third party auth is currently not supported on this client."
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4c3e80831e073dfb051d97f129c9de070cbc4eb

commit b4c3e80831e073dfb051d97f129c9de070cbc4eb
Author: Yuwei Huang <yuweih@chromium.org>
Date: Wed Jan 10 19:36:40 2018

[CRD iOS] Improve third party auth failure message

Third party auth is currently not supported on iOS. For now when the user
connects to a corp device, they will only see a snackbar saying
"[ThirdPartyAuth] unable to authenticate with <machine name>", which is
confusing to the user.

This CL improves it by making the text clearer, and refactors the logic
a bit so that the message is displayed by ClientConnectionVC instead of
RemotingClient.

Bug:  793167 
Change-Id: I5bceb6163149913e1293896415d36ca8e5e69038
Reviewed-on: https://chromium-review.googlesource.com/849490
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528383}
[modify] https://crrev.com/b4c3e80831e073dfb051d97f129c9de070cbc4eb/remoting/ios/app/client_connection_view_controller.mm
[modify] https://crrev.com/b4c3e80831e073dfb051d97f129c9de070cbc4eb/remoting/ios/domain/client_session_details.h
[modify] https://crrev.com/b4c3e80831e073dfb051d97f129c9de070cbc4eb/remoting/ios/session/remoting_client.mm
[modify] https://crrev.com/b4c3e80831e073dfb051d97f129c9de070cbc4eb/remoting/resources/remoting_strings.grd

Comment 2 by yuweih@chromium.org, Jan 10 2018

Status: Fixed (was: Assigned)

Comment 3 by byoshimi@google.com, Jan 26 2018

Is there a reference inside the documentation that defines "ThirdPartyAuth".

I was thinking that the documentation page for the iOS Chromoting app should  state at the very bottom which authentication methods are support and explicitly state that the method used by google.com is not supported.

Comment 4 by yuweih@chromium.org, Jan 29 2018

For documentation page, are you talking about go/chromoting-ios? I can add the list of known issue to that page.
Status: Verified (was: Fixed)
Verifed Fixed in 67.3396.22

Sign in to add a comment