New issue
Advanced search Search tips

Issue 793164 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Handle v8_context_snapshot in gin/

Project Member Reported by peria@chromium.org, Dec 8 2017

Issue description

Now we have many code to load snapshot files;

#ifdef V8_USE_EXTERNAL_STARTUP
LoadV8Snapshot();
#ifdef USE_V8_CONTEXT_SNAPSHOT
LoadV8ContextSnapshot();
#endif
#endif

but now we know that it possible substitute v8_context_snapshot.bin for snapshot_blob.bin. So the above code can be simply

#ifdef V8_USE_EXTERNAL_STARTUP
LoadV8Snapshot();
#endif

and which file to load should be detected in the function LoadV8Snapshot(),
depending on USE_V8_CONTEXT_SNAPSHOT.

 

Comment 1 by peria@chromium.org, Jan 16 2018

Status: WontFix (was: Assigned)
After the investigation, we have to decide which snapshot file to load. So the current interface is needed.

Sign in to add a comment