New issue
Advanced search Search tips

Issue 793154 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

cronet_test_instrumentation_apk failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 8 2017

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ctzsm@google.com

cronet_test_instrumentation_apk failing on multiple builders

Builders failed on: 
- Android Cronet ARMv6 Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder
- Android Cronet Builder (dbg): 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29
- Android Cronet KitKat Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20KitKat%20Builder
- Android Cronet Lollipop Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Lollipop%20Builder
- Android Cronet Marshmallow 64bit Builder: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Marshmallow%2064bit%20Builder
- Android Cronet Marshmallow 64bit Perf: 
  https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Marshmallow%2064bit%20Perf

Caused by
[  FAILED  ] org.chromium.net.NQETest#testPrefsWriteRead
[  FAILED  ] org.chromium.net.NQETest#testQuicDisabled (TIMEOUT)
[  FAILED  ] org.chromium.net.QuicTest#testNQEWithQuic (TIMEOUT)
 

Comment 1 by ctzsm@chromium.org, Dec 8 2017

Cc: ctzsm@chromium.org

Comment 2 by ctzsm@chromium.org, Dec 8 2017

CL for disabling those tests http://crrev/c/816039

Comment 3 by ctzsm@chromium.org, Dec 8 2017

Cc: tbansal@chromium.org
Example build
https://ci.chromium.org/buildbot/chromium.android/Android%20Cronet%20ARMv6%20Builder/6564

ccing test author, feel free to reassign 
Cc: -tbansal@chromium.org
Labels: -Pri-2 Pri-1
Owner: tbansal@chromium.org
Status: Started (was: Available)
Labels: -Sheriff-Chromium
Bug is assigned + disable CL is in CQ, removing from sheriff queue
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d0f58e4b02cafc1299f305a81e7a8b587e21ac0

commit 5d0f58e4b02cafc1299f305a81e7a8b587e21ac0
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Fri Dec 08 01:42:35 2017

Disable failing tests.

This CL is disabling
org.chromium.net.NQETest#testPrefsWriteRead
org.chromium.net.NQETest#testQuicDisabled
org.chromium.net.QuicTest#testNQEWithQuic

TBR=tbansal@chromium.org

Bug:  793154 
Change-Id: I7a082e3c8bd07d5b5b87afc6646f13cc6407eb05
Reviewed-on: https://chromium-review.googlesource.com/816039
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522674}
[modify] https://crrev.com/5d0f58e4b02cafc1299f305a81e7a8b587e21ac0/components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java
[modify] https://crrev.com/5d0f58e4b02cafc1299f305a81e7a8b587e21ac0/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151076c09acc44ed21eb31614636fa211e962b45

commit 151076c09acc44ed21eb31614636fa211e962b45
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Dec 11 17:40:43 2017

Fix NQE Cronet tests

The tests broke due to changes on the Chromium side. Specifically,
those changes optimized when the prefs are written. With the changes,
the prefs may not be written in certain cases.

This CL forces the value of effective connection type
as Slow2G in the tests. This causes the prefs to be always written.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Bug:  793154 
Change-Id: Ie09261da07ed44a78b37d02527e105a1dc72ca6c
Reviewed-on: https://chromium-review.googlesource.com/815949
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523126}
[modify] https://crrev.com/151076c09acc44ed21eb31614636fa211e962b45/components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java
[modify] https://crrev.com/151076c09acc44ed21eb31614636fa211e962b45/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Components: Internals>Network>NetworkQuality
Labels: Merge-Request-64
M64 Merge request for the CL in #7. This CL only changes the behavior of tests, and is essential to make the tests pass on M64.
Please add OSs.
Labels: OS-Android

Comment 11 by ctzsm@chromium.org, Dec 11 2017

Cc: -ctzsm@chromium.org
Labels: -Merge-Request-64
Tarun, Cronet-only changes like this can be merged without waiting for approval as they do not affect Chrome at all.  Please just merge to the 3282 branch ASAP (I'd like this in this week's dev channel release).  If you'd like me to, that's fine too.
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 12 2017

Labels: merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f33a2b5a39e074e63b58da9c14098788bf7239

commit 19f33a2b5a39e074e63b58da9c14098788bf7239
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Dec 12 18:03:39 2017

Fix NQE Cronet tests

The tests broke due to changes on the Chromium side. Specifically,
those changes optimized when the prefs are written. With the changes,
the prefs may not be written in certain cases.

This CL forces the value of effective connection type
as Slow2G in the tests. This causes the prefs to be always written.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Bug:  793154 
Change-Id: Ie09261da07ed44a78b37d02527e105a1dc72ca6c
Reviewed-on: https://chromium-review.googlesource.com/815949
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523126}(cherry picked from commit 151076c09acc44ed21eb31614636fa211e962b45)
Reviewed-on: https://chromium-review.googlesource.com/822133
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#174}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/19f33a2b5a39e074e63b58da9c14098788bf7239/components/cronet/android/test/javatests/src/org/chromium/net/NQETest.java
[modify] https://crrev.com/19f33a2b5a39e074e63b58da9c14098788bf7239/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Cc: pauljensen@chromium.org
Labels: M-64
Status: Fixed (was: Started)
The fix has been merged to M-64 branch.

Sign in to add a comment