New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793153 link

Starred by 1 user
Status: Fixed
Owner:
█ imch...@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Media Router] in-browser discovery does not prevent extension-side discovery

Project Member Reported by imch...@chromium.org, Dec 8 2017 
This is a recently introduced regression due to the migration of JS bindings.

Steps to repro:

1) Enable in-browser cast discovery
2) Open the dev console of the MR extension's background page
3) Type in "chrome.mdns.onServiceList.hasListeners()"

Expected: false
Actual: true
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25b7dd1729eebe969f4bfd358babec31b96589ca

commit 25b7dd1729eebe969f4bfd358babec31b96589ca
Author: Derek Cheng <imcheng@chromium.org>
Date: Fri Dec 08 01:15:07 2017

[Media Router] Fix return value of MediaRouter.start in JS bindings.

The recent migration to new JS bindings introduced a bug where the
response object returned to the extension in MediaRouter.start() is not
properly formatted.

Bug:  793153 
Change-Id: I8d8dfdb1248333e9da72a70a589c2fb90ced0cb1
Reviewed-on: https://chromium-review.googlesource.com/816036
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522666}
[modify] https://crrev.com/25b7dd1729eebe969f4bfd358babec31b96589ca/chrome/renderer/resources/extensions/media_router_bindings.js

Comment 2 by imch...@chromium.org, Dec 8 2017

Status: Fixed (was: Started)
►

Sign in to add a comment