New issue
Advanced search Search tips

Issue 793137 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

Send MCC/MNC on Data Saver client config request

Project Member Reported by alsu@google.com, Dec 7 2017

Issue description

Feature description: For mobile devices with Data Saver enabled, Chrome
can report MCC/MNC on its request to fetch a client config.

Eng owner: tbansal (at least for initial triage)
Product owner:

Design doc: N/A

Are you planning on experimenting before launch?
Any new strings?
Any implications for Google webservices (i.e. sync, translate)?
Binary size?
Do the existing perf tests exercise all aspects of your new feature(s)?

 
Components: Internals>Network>DataProxy
Labels: -Restrict-View-Google
Owner: ryansturm@chromium.org
Looking at the Q4 OKRs, this is already on ryansturm@ plate. Please feel free to assign back if I am not reading the OKRs correctly.
alsu, Is this on client config or C-P header? I'd understand wanting it on either.

Comment 3 by alsu@google.com, Dec 8 2017

ultimately, it'd be good to know it at the time that a client config is being generated.  however, if work is already under way to get it included in C-P (and it would require substantial additional effort to get it on the client config request), then we can at least use that signal to validate other carrier signals we're considering.
Client Config is easier to do; I'd prefer it.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63576d29e15e56eee6e2c50364c4e5a92d5b74df

commit 63576d29e15e56eee6e2c50364c4e5a92d5b74df
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Tue Dec 12 19:34:40 2017

Adding MCC/MNC to Data_reduction_proxy ClientConfig

Bug:  793137 
Change-Id: Ifb14055f98fbe75523aaca6d61cf0ed85b9ef70c
Reviewed-on: https://chromium-review.googlesource.com/820560
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523509}
[modify] https://crrev.com/63576d29e15e56eee6e2c50364c4e5a92d5b74df/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_service_client.cc
[modify] https://crrev.com/63576d29e15e56eee6e2c50364c4e5a92d5b74df/components/data_reduction_proxy/proto/client_config.proto

Status: Fixed (was: Assigned)

Sign in to add a comment