[iOS] Disable FullscreenController for scenarios described by notifications handled by LegacyFullscreenController. |
||||||||||||||
Issue descriptionLegayFullscreenController registers for several notifications corresponding to starting and stopping pieces of UI for which fullscreen should be disabled. Since the new FullscreenController is a KeyedService, it can be accessed and enabled/disabled by the UI implementations themselves rather than relying on notifications. This is an umbrella bug, and is considered fixed once all blocking bugs have been fixed.
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
,
Dec 7 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 12 2017
,
Dec 13 2017
,
Dec 15 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6cb4b637951be3274d4a0c90a95596bb7508985 commit e6cb4b637951be3274d4a0c90a95596bb7508985 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Dec 21 18:10:08 2017 [iOS] Created ChromeCoordinator category for disabling fullscreen. This will help eliminate code duplication for coordinators that present UI that requires the toolbar to be fully visible. Bug: 793128 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61c4747c0bd9f6ac43d5922b4a95a36c2fa0c40a Reviewed-on: https://chromium-review.googlesource.com/827615 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#525738} [modify] https://crrev.com/e6cb4b637951be3274d4a0c90a95596bb7508985/ios/chrome/browser/ui/fullscreen/BUILD.gn [add] https://crrev.com/e6cb4b637951be3274d4a0c90a95596bb7508985/ios/chrome/browser/ui/fullscreen/chrome_coordinator+fullscreen_disabling.h [add] https://crrev.com/e6cb4b637951be3274d4a0c90a95596bb7508985/ios/chrome/browser/ui/fullscreen/chrome_coordinator+fullscreen_disabling.mm
,
Dec 23 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by kkhorimoto@chromium.org
, Dec 7 2017