New issue
Advanced search Search tips

Issue 793126 link

Starred by 1 user
Status: WontFix
Owner:
w...@chromium.org
Closed: Dec 2017
Cc:
jbudorick@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Enable DCHECKs on Fuchsia Release build-bots

Project Member Reported by w...@chromium.org, Dec 7 2017 
Chromium's Release builders usually build with DCHECKs enabled, to allow tests to catch violated assertions; we should try enabling them on the Fuchsia Release builders as well.

Comment 1 by scottmg@chromium.org, Dec 7 2017 

I believe most platforms only do dcheck_always_on=true on trybots, but not waterfall bots, so we should probably stick to the standard thing.

Comment 2 by w...@chromium.org, Dec 7 2017 

Looking at some of the generate_build_files steps, that does seem to be
correct.

That means that our (Fuchsia) waterfall is running without DCHECKs being
checked (since we have no Debug bot there yet), which seems unfortunate.

Comment 3 by w...@chromium.org, Dec 7 2017

Status: WontFix (was: Assigned)

Comment 4 by jbudorick@chromium.org, Dec 8 2017 

yep, this is correct. Debug is expected to hit DCHECKs on the waterfall.
►

Sign in to add a comment