New issue
Advanced search Search tips

Issue 793124 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 784944



Sign in to add a comment

tast: Run both local and remote tests

Project Member Reported by derat@chromium.org, Dec 7 2017

Issue description

The tast command's "run" subcommand currently accepts a -type flag indicating whether local or remote tests should be run. It'd be nice to support executing both types of tests in a single run.

This is separate from supporting test bundles ( issue 784944 ).
 

Comment 1 by derat@chromium.org, Jan 14 2018

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/3636b51b40ff086f8dc234ea0b99e126675cee17

commit 3636b51b40ff086f8dc234ea0b99e126675cee17
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jan 18 22:44:47 2018

tast: Refactor to support mixed local/remote runs.

Change the chromiumos/cmd/tast/run package's Local and
Remote functions to return test results instead of writing
them to the results dir immediately. This will allow the
"run" subcommand to run both local and remote tests and
concatenate the results before writing them using a new
WriteResults function.

No functional changes intended (apart from adding the number
of tests that were run to the final messages logged by Local
and Remote).

BUG= chromium:793124 
TEST=updated tests; also performed local and remote runs and
     checked that results.json is written to results dir

Change-Id: I2e2af85151e9746f70980ffb61cef45f8b2799d1
Reviewed-on: https://chromium-review.googlesource.com/865467
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run/remote.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run/results_test.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run_cmd.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run/local.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run/local_test.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/list_cmd.go
[modify] https://crrev.com/3636b51b40ff086f8dc234ea0b99e126675cee17/src/chromiumos/cmd/tast/run/results.go

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/7374bead60a5aa76d316ddcb54c4983873524acd

commit 7374bead60a5aa76d316ddcb54c4983873524acd
Author: Daniel Erat <derat@chromium.org>
Date: Fri Jan 19 08:29:45 2018

tast-tests: Add "bvt" attribute to power.Reboot test.

Add the power.Reboot remote test to the BVT suite.

BUG= chromium:793124 
TEST=none

Change-Id: I5cc869e86ffb6af3055cbfcf3eba5dd403118d7a
Reviewed-on: https://chromium-review.googlesource.com/872253
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/7374bead60a5aa76d316ddcb54c4983873524acd/src/chromiumos/tast/remote/bundles/cros/power/reboot.go

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/0218b0d8fca9220243686af0a56c37576af626cf

commit 0218b0d8fca9220243686af0a56c37576af626cf
Author: Daniel Erat <derat@chromium.org>
Date: Sat Jan 20 01:18:05 2018

tast: Run both local and remote tests when not building.

Make the "tast run" command run both local and remote tests
when the -build flag is false.

Also rename -type to -buildtype now that it's only relevant
when -build is true.

BUG= chromium:793124 
TEST=ran with -build=false and checked that both local and
     remote tests are executed and that results.json
     contains all tests

Change-Id: I2cb25e8d298a0de5d4590faab449228f10728686
Reviewed-on: https://chromium-review.googlesource.com/875299
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[modify] https://crrev.com/0218b0d8fca9220243686af0a56c37576af626cf/src/chromiumos/tast/runner/runner_test.go
[modify] https://crrev.com/0218b0d8fca9220243686af0a56c37576af626cf/src/chromiumos/tast/runner/runner.go
[modify] https://crrev.com/0218b0d8fca9220243686af0a56c37576af626cf/src/chromiumos/cmd/tast/run_cmd.go
[modify] https://crrev.com/0218b0d8fca9220243686af0a56c37576af626cf/docs/running_tests.md

Comment 5 by derat@chromium.org, Jan 23 2018

Components: Tests>Tast

Comment 6 by derat@chromium.org, Jan 23 2018

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/812c5f1be69deb46fe043c4cf1daa7798e7b4d7e

commit 812c5f1be69deb46fe043c4cf1daa7798e7b4d7e
Author: Daniel Erat <derat@chromium.org>
Date: Thu Jan 25 04:24:44 2018

tast: Add tests for runCmd.

Add unit tests for the tast command's runCmd struct.

BUG= chromium:793124 
TEST=new tests pass

Change-Id: I1d6ad28427305ebb4b37c238c769f55854327e8e
Reviewed-on: https://chromium-review.googlesource.com/882398
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[add] https://crrev.com/812c5f1be69deb46fe043c4cf1daa7798e7b4d7e/src/chromiumos/cmd/tast/run_cmd_test.go
[modify] https://crrev.com/812c5f1be69deb46fe043c4cf1daa7798e7b4d7e/src/chromiumos/cmd/tast/run_cmd.go
[modify] https://crrev.com/812c5f1be69deb46fe043c4cf1daa7798e7b4d7e/src/chromiumos/cmd/tast/main.go

Sign in to add a comment