Fix the Verified Access default public signing key |
||||||||||
Issue descriptionThis change: https://chromium-review.git.corp.google.com/c/chromiumos/platform2/+/791452/7/cryptohome/attestation.cc#117 accidentally removed the head bytes of the key, making all VA challenges fail.
,
Dec 8 2017
,
Dec 8 2017
,
Dec 8 2017
,
Dec 8 2017
I tagged as a dev blocker per my IM with Yves: "...it prevents anybody at Google from getting on the Corp Wifi network." I also added the other labels per that IM.
,
Dec 8 2017
Approving merge to M64 Chrome OS.
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d2e67fcd316e9c3bbac3e31d7b92506a50a0c7a8 commit d2e67fcd316e9c3bbac3e31d7b92506a50a0c7a8 Author: Yves Arrouye <drcrash@google.com> Date: Fri Dec 08 11:59:17 2017 cryptohome: fix the default public Verified Access signing key BUG= chromium:793122 TEST=unit tests Change-Id: If0d9550973e5a435dd3659e938aedf977331cf02 Reviewed-on: https://chromium-review.googlesource.com/815896 Commit-Ready: Yves Arrouye <drcrash@chromium.org> Tested-by: Yves Arrouye <drcrash@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/d2e67fcd316e9c3bbac3e31d7b92506a50a0c7a8/cryptohome/attestation.cc
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/919cfbeb6dcaf15023a9978742a02c192df1a652 commit 919cfbeb6dcaf15023a9978742a02c192df1a652 Author: Yves Arrouye <drcrash@google.com> Date: Fri Dec 08 17:20:48 2017 cryptohome: fix the default public Verified Access signing key BUG= chromium:793122 TEST=unit tests Change-Id: If0d9550973e5a435dd3659e938aedf977331cf02 Reviewed-on: https://chromium-review.googlesource.com/815896 Commit-Ready: Yves Arrouye <drcrash@chromium.org> Tested-by: Yves Arrouye <drcrash@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> (cherry picked from commit d2e67fcd316e9c3bbac3e31d7b92506a50a0c7a8) Reviewed-on: https://chromium-review.googlesource.com/817874 Commit-Queue: Yves Arrouye <drcrash@chromium.org> Trybot-Ready: Yves Arrouye <drcrash@chromium.org> [modify] https://crrev.com/919cfbeb6dcaf15023a9978742a02c192df1a652/cryptohome/attestation.cc
,
Dec 11 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 12 2017
,
Dec 12 2017
Hi, can this be tagged as fixed? Right now it's still tagged as open and a blocker. Thanks
,
Dec 12 2017
,
Dec 12 2017
I marked it Verified. Kevin made it a blocker, I'll let him manage that.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/tpm/+/f4dd2faedc467ebe4d37bb21e54dc1afcc4c3bda commit f4dd2faedc467ebe4d37bb21e54dc1afcc4c3bda Author: Yves Arrouye <drcrash@google.com> Date: Wed Dec 13 00:21:35 2017 attestation: add a command line switch to specify the VA servers One can use --va_server=default|test to specify the VA servers to use when signing enterprise challenges. BUG= chromium:793122 TEST=manual Change-Id: I6d3651011e944621f44786505b3ff93fd9b836d3 Reviewed-on: https://chromium-review.googlesource.com/818633 Commit-Ready: Yves Arrouye <drcrash@chromium.org> Tested-by: Yves Arrouye <drcrash@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/f4dd2faedc467ebe4d37bb21e54dc1afcc4c3bda/attestation/client/main.cc
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/cf54d499e5b9314e4d1810bdc08ff6af25dafcef commit cf54d499e5b9314e4d1810bdc08ff6af25dafcef Author: Yves Arrouye <drcrash@google.com> Date: Wed Dec 13 20:33:38 2017 cryptohome: add the ability to select the Verified Access servers One can use either the --va-server command line switch, or piggyback off the --attestation-server switch (like Chromium does). BUG= chromium:793122 TEST=manual Change-Id: I0dc4795d1b497155e740725efcf935c3a6e37d03 Reviewed-on: https://chromium-review.googlesource.com/817389 Commit-Ready: Yves Arrouye <drcrash@chromium.org> Tested-by: Yves Arrouye <drcrash@chromium.org> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/cf54d499e5b9314e4d1810bdc08ff6af25dafcef/cryptohome/cryptohome.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by drcrash@chromium.org
, Dec 8 2017