Help Center link in Material Design bookmarks |
||||
Issue descriptionFeature description: Add link to help center in Material Design bookmarks https://screenshot.googleplex.com/6K0naFnyhMb Link to use: https://support.google.com/chrome/?p=bookmarks (track creation: https://b2.corp.google.com/u/0/issues/70348464) Eng owner: Product owner: <b>Design doc: <see http://go/DesignDocTemplates></b> Are you planning on experimenting before launch? Any new strings? Any implications for Google webservices (i.e. sync, translate)? Binary size? Do the existing perf tests exercise all aspects of your new feature(s)?
,
Dec 11 2017
I appear to be CC when someone else was intended?
,
Jan 8 2018
,
Jan 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34be1499c5438ad288712fddb8a7f9c0bf625971 commit 34be1499c5438ad288712fddb8a7f9c0bf625971 Author: Christopher Lam <calamity@chromium.org> Date: Wed Jan 17 11:01:28 2018 [MD Bookmarks] Add Help Center link to toolbar menu. Bug: 793107 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8940ea5df6d1d453983e687a397be00832f39298 Reviewed-on: https://chromium-review.googlesource.com/853812 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Cr-Commit-Position: refs/heads/master@{#529702} [modify] https://crrev.com/34be1499c5438ad288712fddb8a7f9c0bf625971/chrome/app/bookmarks_strings.grdp [modify] https://crrev.com/34be1499c5438ad288712fddb8a7f9c0bf625971/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/34be1499c5438ad288712fddb8a7f9c0bf625971/chrome/browser/resources/md_bookmarks/constants.js [modify] https://crrev.com/34be1499c5438ad288712fddb8a7f9c0bf625971/chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc [modify] https://crrev.com/34be1499c5438ad288712fddb8a7f9c0bf625971/tools/metrics/histograms/enums.xml
,
Jan 18 2018
Verified the fix on Mac 10.12.6, Win-10 and Ubuntu 14.04 using latest Chrome version #65.0.3324.0 as per the comment# 0 Attaching screen shot for reference. Observed that help center link is added to Material Design bookmarks Hence, the fix is working as expected. Adding the verified labels. Thanks...!!
,
Jan 18 2018
,
Jan 18 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tapted@chromium.org
, Dec 8 2017Labels: Proj-MaterialDesign-WebUI