New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793106 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Check force_effective_connection_type through fieldtrial flag

Project Member Reported by thanhdle@chromium.org, Dec 7 2017

Issue description

In addition to --force-effective-connection-type, ECT can also be forced through field trial flags (--force-fieldtrials and --force-fieldtrial-params).

chrome://interventions-internals page should check for these flags as well for the description shown in the ECT flag value.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87ee9fb790b8cf8a08852581979c0d4563e91d06

commit 87ee9fb790b8cf8a08852581979c0d4563e91d06
Author: Thanh Le <thanhdle@chromium.org>
Date: Thu Dec 21 22:43:03 2017

Check forced ect in force-fieldtrial-params.

In addition to --force-effective-connection-type, ECT can also be forced
through field trial flags (--force-fieldtrials and
--force-fieldtrial-params).

chrome://interventions-internals page checks for these flags as well as
the forced effective connection type flag in chrome://flags.

Screenshot:
https://drive.google.com/a/chromium.org/file/d/1Nc91EK_X1vj9ub0aHUCYdyMTJnRr73eQ

Bug:  793106 
Change-Id: Id9a05b9dc97422d839b19b69df1c4cb1e7adcb28
Reviewed-on: https://chromium-review.googlesource.com/834880
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525837}
[modify] https://crrev.com/87ee9fb790b8cf8a08852581979c0d4563e91d06/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/87ee9fb790b8cf8a08852581979c0d4563e91d06/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment