MD Extensions: A11y: Origin Chip not announced by VoiceOver on Mac |
||||||||||||
Issue description1. Navigate to chrome://extensions 2. Make sure you have an extension installed from a non-webstore location. (Load unpacked, or by enterprise policy) 3. Use VocieOver to navigate to the chip (see screenshot) It's expected that voice over will read the label, but voice over just says "Image"
,
Dec 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14097cda832fbb7a3cf87a4f05cb7d684b49a5dc commit 14097cda832fbb7a3cf87a4f05cb7d684b49a5dc Author: Hector Carmona <hcarmona@chromium.org> Date: Sat Dec 09 00:00:28 2017 MD Extension: A11y - Change aria-labelledby to aria-label for VoiceOver. The element that was used for the aria-labelledby portion was hidden, this caused VoiceOver to not read the text. Bug: 793094 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4905d677ad5ff7ae42f17890338e31fd8b0b6b14 Reviewed-on: https://chromium-review.googlesource.com/815680 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#522927} [modify] https://crrev.com/14097cda832fbb7a3cf87a4f05cb7d684b49a5dc/chrome/browser/resources/md_extensions/item.html
,
Dec 11 2017
Requesting merge to M64. This is not a complex fix and will address an a11y issue on MacOS. Issue is on canary, no regressions have been found.
,
Dec 11 2017
,
Dec 11 2017
Approving merge to M64. Branch:3282
,
Dec 11 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30ac6fa4930b51c6bfa0c15b0a3e82a1f34918ac commit 30ac6fa4930b51c6bfa0c15b0a3e82a1f34918ac Author: Hector Carmona <hcarmona@chromium.org> Date: Mon Dec 11 22:44:29 2017 MD Extension: A11y - Change aria-labelledby to aria-label for VoiceOver. The element that was used for the aria-labelledby portion was hidden, this caused VoiceOver to not read the text. Bug: 793094 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4905d677ad5ff7ae42f17890338e31fd8b0b6b14 Reviewed-on: https://chromium-review.googlesource.com/815680 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522927}(cherry picked from commit 14097cda832fbb7a3cf87a4f05cb7d684b49a5dc) Reviewed-on: https://chromium-review.googlesource.com/820931 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#153} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/30ac6fa4930b51c6bfa0c15b0a3e82a1f34918ac/chrome/browser/resources/md_extensions/item.html
,
Dec 11 2017
,
Dec 12 2017
Tested this issue on Mac 10.12.6 with chrome #64.0.3282.24 Steps followed: 1. Installed unpacked extension 2. Enabled voice over 3. Navigated to chrome://extensions Observations: 1. On selecting extension icon, voiceover read as "Image" 2. Unable to read the extension Source indicator 3. On inspecting the Extension source indicator, observed the element used as "aria-label" Attaching the screencast for reference. hcarmona@ Could you confirm that this is the expected behaviour of this issue. Thank You...
,
Dec 12 2017
Icon is still an image, so "image" will also be read, but the bug fix is that it also reads the label on the orange icon. See screencast
,
Dec 12 2017
Trying upload again
,
Dec 12 2017
hcarmona@, thank you for the clarification. It is working as intended on Latest M64#64.0.3202.24 for OS X 10.13.3 Beta. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by hcarmona@chromium.org
, Dec 8 2017