New issue
Advanced search Search tips

Issue 793081 link

Starred by 1 user
Status: Fixed
Owner:
ma...@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Autofill] Save Card Bubble is not immediately dismissable unless you click in it

Project Member Reported by ma...@chromium.org, Dec 7 2017 
Repro:
Visit https://dump-truck.appspot.com/usecase-address_then_cc_text/ , Click “Start”, “Fill with Default Values”, “Submit”, “Fill with Default Values”, “Submit”.

There should be a dialog asking you to save a credit card. To dismiss it, you need to click inside it and then click outside it. Instead, we should be able to click in the content area to dismiss it directly after it's shown.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11e482085e09fa1f2a8baf56155228de6a517cbf

commit 11e482085e09fa1f2a8baf56155228de6a517cbf
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Dec 11 15:38:31 2017

[Autofill] Save Card Bubble: Register a WebContentsMouseHandler

Allows the bubble to be dismissed when the web contents is clicked, even
if the bubble has not been interacted with.

Bug:  793081 , 624560
Change-Id: I9597bd8162db2fdc82a821621d28a301165fa7a1
Reviewed-on: https://chromium-review.googlesource.com/816394
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523101}
[modify] https://crrev.com/11e482085e09fa1f2a8baf56155228de6a517cbf/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/11e482085e09fa1f2a8baf56155228de6a517cbf/chrome/browser/ui/views/autofill/save_card_bubble_views.h

Comment 2 by ma...@chromium.org, Dec 11 2017

Status: Fixed (was: Assigned)

Comment 3 by ma...@chromium.org, Dec 12 2017

Labels: Merge-Request-64
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 13 2017

Labels: -Merge-Request-64 Hotlist-Merge-Approved Merge-Approved-64
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 14 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f46536e64f9ed715b623fd9dac82009e62049d9d

commit f46536e64f9ed715b623fd9dac82009e62049d9d
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Dec 14 15:37:19 2017

[Merge M64] [Autofill] Save Card Bubble: Register a WebContentsMouseHandler

Allows the bubble to be dismissed when the web contents is clicked, even
if the bubble has not been interacted with.

TBR=mathp@chromium.org

(cherry picked from commit 11e482085e09fa1f2a8baf56155228de6a517cbf)

Bug:  793081 , 624560
Change-Id: I9597bd8162db2fdc82a821621d28a301165fa7a1
Reviewed-on: https://chromium-review.googlesource.com/816394
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523101}
Reviewed-on: https://chromium-review.googlesource.com/827030
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#228}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/f46536e64f9ed715b623fd9dac82009e62049d9d/chrome/browser/ui/views/autofill/save_card_bubble_views.cc
[modify] https://crrev.com/f46536e64f9ed715b623fd9dac82009e62049d9d/chrome/browser/ui/views/autofill/save_card_bubble_views.h
►

Sign in to add a comment