To repro: <button>Foo</button> <script> setTimeout(function() { document.querySelector('button').textContent = 'Bar'; }, 100); Load the page, then check the accessibility tree, it will still show "Foo".
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2 commit 17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2 Author: Philip Jägenstedt <foolip@chromium.org> Date: Fri Dec 08 13:13:49 2017 Reland "Make elements outside of the fullscreen element inert" This is a reland of f3535b851736a4163abee41073c753d7cdf714d5 The IgnoreElementsOutsideFullscreenElement test was originally flaky, due to changing textContent not reliably causing the accessibility tree to be updated. See https://crbug.com/793078 . Original change's description: > Make elements outside of the fullscreen element inert > > There is no spec for this, but an old open spec issue: > https://github.com/whatwg/fullscreen/issues/15 > > Bug: 787867 > Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a > Reviewed-on: https://chromium-review.googlesource.com/788052 > Commit-Queue: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520620} Bug: 787867 , 793078 Change-Id: I5ddc56a8783dce77acf02728afc9ed621145e222 Reviewed-on: https://chromium-review.googlesource.com/810584 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#522771} [add] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/content/browser/accessibility/fullscreen_browsertest.cc [modify] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/content/test/BUILD.gn [add] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/content/test/data/accessibility/fullscreen/links.html [modify] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/third_party/WebKit/LayoutTests/fullscreen/full-screen-contentEditable-crash-expected.txt [add] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/third_party/WebKit/LayoutTests/fullscreen/keyboard-focus.html [modify] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2/third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b078ac342807ec59b7b994d8e59145d698337e72 commit b078ac342807ec59b7b994d8e59145d698337e72 Author: Philip Jägenstedt <foolip@chromium.org> Date: Thu Dec 14 10:13:04 2017 Reland "Make elements outside of the fullscreen element inert" This is a reland of f3535b851736a4163abee41073c753d7cdf714d5 The IgnoreElementsOutsideFullscreenElement test was originally flaky, due to changing textContent not reliably causing the accessibility tree to be updated. See https://crbug.com/793078 . Original change's description: > Make elements outside of the fullscreen element inert > > There is no spec for this, but an old open spec issue: > https://github.com/whatwg/fullscreen/issues/15 > > Bug: 787867 > Change-Id: Icde796405fca96e910480aef6f0d6be835f7a27a > Reviewed-on: https://chromium-review.googlesource.com/788052 > Commit-Queue: Philip Jägenstedt <foolip@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520620} Bug: 736832 , 787867 , 793078 Change-Id: I5ddc56a8783dce77acf02728afc9ed621145e222 Reviewed-on: https://chromium-review.googlesource.com/810584 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#522771}(cherry picked from commit 17dd72fb55aaa071bf1077a02e45b9f2f44d1ed2) Reviewed-on: https://chromium-review.googlesource.com/826943 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#223} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [add] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/content/browser/accessibility/fullscreen_browsertest.cc [modify] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/content/test/BUILD.gn [add] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/content/test/data/accessibility/fullscreen/links.html [modify] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/third_party/WebKit/LayoutTests/fullscreen/full-screen-contentEditable-crash-expected.txt [add] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/third_party/WebKit/LayoutTests/fullscreen/keyboard-focus.html [modify] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/third_party/WebKit/Source/core/dom/Node.cpp [modify] https://crrev.com/b078ac342807ec59b7b994d8e59145d698337e72/third_party/WebKit/Source/core/fullscreen/Fullscreen.cpp
The other patches on this bug look unrelated?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a64677500027ed83a9585040feb8a46438e7c58 commit 1a64677500027ed83a9585040feb8a46438e7c58 Author: James Wallace-Lee <jamwalla@chromium.org> Date: Wed Jun 27 15:42:56 2018 Notify textChanged if button's children change When a button's textContent changes, post a textChanged notification. A button's textContent is a child of the button container, but in the accessibility tree button elements cannot have children, so ChildrenChanged previously did not update the button. Bug: 793078 Test: DumpAccessibilityTreeTest.AccessibilityButtonContentChanged Change-Id: I2be389c77763cb60fd2fc9951070370856b0c894 Reviewed-on: https://chromium-review.googlesource.com/1110658 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#570786} [modify] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/content/browser/accessibility/dump_accessibility_tree_browsertest.cc [add] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/content/test/data/accessibility/html/button-alt-changed-expected-blink.txt [add] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/content/test/data/accessibility/html/button-alt-changed.html [add] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/content/test/data/accessibility/html/button-content-changed-expected-blink.txt [add] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/content/test/data/accessibility/html/button-content-changed.html [modify] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/third_party/blink/renderer/core/dom/ax_object_cache.h [modify] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/third_party/blink/renderer/core/dom/container_node.cc [modify] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc [modify] https://crrev.com/1a64677500027ed83a9585040feb8a46438e7c58/third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
Comment 1 by bugdroid1@chromium.org
, Dec 8 2017