bookmarks bubble and passwords bubbles should still be drawn with Cocoa UI if #secondary-ui-md is disabled. Cocoa UI always has an arrow.

With chrome://flags/#enable-macviews-credit-card-dialogs enabled, and #secondary-ui-md disabled.. the arrow should still be present. That's true for permissions bubbles which are using views on Mac always, but they can't be summoned from location icon clicks.

It's probably this code:

void LocationBarBubbleDelegateView::ShowForReason(DisplayReason reason) {
  if (reason == USER_GESTURE) {
    // In the USER_GESTURE case, the icon will be in an active state so the
    // bubble doesn't need an arrow.
    SetArrowPaintType(views::BubbleBorder::PAINT_TRANSPARENT);
    GetWidget()->Show();
  } else {
    GetWidget()->ShowInactive();
  }
}


regression from r420142 "Remove non-md code in location bar (Views)." ? That m55 though - over a year old.

Seems that what Windows does though -- location bar bubbles have no arrows when summoned from a user gesture (and that flag is passed through properly). PageInfo, permissions, extension bubbles always have an arrow.

On Mac we probably want to be consistent with the Cocoa dialogs in m64. So if chrome://flags/#enable-macviews-credit-card-dialogs rolls out before secondary-ui-md PAINT_TRANSPARENT should be skipped.

Evan, Hwi, please let us know what is your opinion. This affects all Views bubbles, not only Mac.

Currently:
MD or NON-MD - No Arrow on USER_GESTURE (icon click), all Views platforms

Proposal put forward:
MD - No Arrow on USER_GESTURE, all Views platforms
NON-MD - Arrow on MacViews, no arrow on the Windows/CrOS/Linux?

"This affects all Views bubbles, not only Mac."

Despite the above assertion, your proposal seems to leave non mac alone. I'm fine with that. I don't have an educated opinion about what mac ought to be doing.

Sounds fine to me as long as it's a quick fix on Mac. This slightly helps consistency within Mac. If the fix is highly costly, I wouldn't worry too much given that MD is underway and the anchor icon is highlighted on USER_GESTURE. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d95b081ed90927fc0a82cea5e396555dcae62119

commit d95b081ed90927fc0a82cea5e396555dcae62119
Author: Mathieu Perreault <mathp@chromium.org>
Date: Mon Dec 11 15:17:58 2017

[Views] Draw an arrow for location bar bubbles on Mac, pre Material

On Views, there is no arrow draw if the bubble shows up on a user
gesture. For consistency, an arrow is now drawn on Mac, pre Material
Design.

Bug:  793077 
Test: visual
Change-Id: Ic73856c6b07cdc3b5821fec918d44cd458847d04
Reviewed-on: https://chromium-review.googlesource.com/818154
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523096}
[modify] https://crrev.com/d95b081ed90927fc0a82cea5e396555dcae62119/chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.cc