Issue metadata
Sign in to add a comment
|
proxy_resolving_client_socket.cc potentially retry Direct twice |
||||||||||||||||||||||
Issue descriptionproxy_reslving_client_socket.cc fall backs to proxy_info.UseDirect(). This might result in retrying direct twice. ReconsiderProxyAfterError() will also retry direct. Filling a bug to fix this.
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5f76123aea5f7e5fb7a7c6cc5c99d9cab4a3e0a3 commit 5f76123aea5f7e5fb7a7c6cc5c99d9cab4a3e0a3 Author: Helen Li <xunjieli@chromium.org> Date: Fri Jan 05 00:11:53 2018 Fix proxy_resolving_client_socket.cc to not retry Direct twice proxy_resolving_client_socket.cc uses net::ProxyService::ReconsiderProxyAfterError(), which will retry "Direct" connection if applicable. There is no need for proxy_resolving_client_socket.cc to retry direct separately. This CL removes the duplicate retry path. Bug: 793076 Change-Id: I20d5e05267a2ade1862f1b1084f085f445ace282 Reviewed-on: https://chromium-review.googlesource.com/847426 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#527158} [modify] https://crrev.com/5f76123aea5f7e5fb7a7c6cc5c99d9cab4a3e0a3/services/network/public/cpp/proxy_resolving_client_socket.cc [modify] https://crrev.com/5f76123aea5f7e5fb7a7c6cc5c99d9cab4a3e0a3/services/network/public/cpp/proxy_resolving_client_socket.h [modify] https://crrev.com/5f76123aea5f7e5fb7a7c6cc5c99d9cab4a3e0a3/services/network/public/cpp/proxy_resolving_client_socket_unittest.cc
,
Jan 5 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by xunji...@chromium.org
, Dec 11 2017