New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793066 link

Starred by 1 user
Status: Fixed
Owner:
█ xunji...@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
█ xunji...@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 721401



Sign in to add a comment

proxy_resolving_client_socket.cc should not create a net::HttpNetworkSession::Context per socket

Project Member Reported by xunji...@chromium.org, Dec 7 2017 
proxy_resolving_client_socket.cc currently creates one SessionContext per socket. This is too resource intensive.

We also need to disable H2 and QUIC proxies for SessionContext created for this purpose.

These need to be addressed before migrating it to mojo.

Comment 1 by xunji...@chromium.org, Dec 11 2017

Components: Internals>Services>Network
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 29 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5551160acdfd8e19f0d12f79e7777b3fcb47762

commit a5551160acdfd8e19f0d12f79e7777b3fcb47762
Author: Helen Li <xunjieli@chromium.org>
Date: Mon Jan 29 15:51:09 2018

Make ProxyResolvingClientSocket not create a new network session for each socket

ProxyResolvingClientSocket creates a fresh HttpNetworkSession for each socket.
This is very expensive. This CL creates a factory class which takes care of
creating network session, so it can be shared across different socket instances.
This will also make mojoifying this class easier because NetworkContext can be
re-used.

A follow-up CL will disable H2 and QUIC proxies on the HttpNetworkSession
created for this purpose (more please see linked bug).

Bug:  793066 
Change-Id: I7b942db3246915abd0ce755ca1f9f29349b50776
Reviewed-on: https://chromium-review.googlesource.com/860198
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532442}
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_dispatcher_host.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_dispatcher_host.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host_tcp.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host_tcp.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host_tcp_server.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/jingle/glue/xmpp_client_socket_factory.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/jingle/glue/xmpp_client_socket_factory.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/net/socket/client_socket_pool_manager.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/net/socket/client_socket_pool_manager.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/remoting/signaling/xmpp_signal_strategy.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/BUILD.gn
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/proxy_resolving_client_socket.cc
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/proxy_resolving_client_socket.h
[add] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/proxy_resolving_client_socket_factory.cc
[add] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/proxy_resolving_client_socket_factory.h
[modify] https://crrev.com/a5551160acdfd8e19f0d12f79e7777b3fcb47762/services/network/public/cpp/proxy_resolving_client_socket_unittest.cc

Comment 3 by xunji...@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)

Comment 4 by xunji...@chromium.org, Jan 29 2018

Cc: mmenke@chromium.org xunji...@chromium.org
 Issue 801321  has been merged into this issue.
►

Sign in to add a comment