New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793058 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Improve search function in chrome://interventions-internals logs

Project Member Reported by thanhdle@chromium.org, Dec 7 2017

Issue description

Since logs are grouped together, the current search functions does not search in the detailed log rows.

The search function should reveal hidden row that contains keyword. 
 
Owner: thanhdle@chromium.org
Components: Blink>Previews
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79f3441bc4666a4cbd61ed891174dc0ae32c65d1

commit 79f3441bc4666a4cbd61ed891174dc0ae32c65d1
Author: Thanh Le <thanhdle@chromium.org>
Date: Mon Dec 18 23:48:43 2017

Improve search bar in chrome://interventions-internals.

The filter can now search in expansion rows of the table. The expansion
row automatically expands when it contains the keyword.

Added 'Expand all' and 'Collapse all' toggle buttons.

Bug:  793058 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4ad1f78dfbcad523f445219aa268d3fa702e3a59
Reviewed-on: https://chromium-review.googlesource.com/832934
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524864}
[modify] https://crrev.com/79f3441bc4666a4cbd61ed891174dc0ae32c65d1/chrome/browser/resources/interventions_internals/index.css
[modify] https://crrev.com/79f3441bc4666a4cbd61ed891174dc0ae32c65d1/chrome/browser/resources/interventions_internals/index.html
[modify] https://crrev.com/79f3441bc4666a4cbd61ed891174dc0ae32c65d1/chrome/browser/resources/interventions_internals/index.js

Sign in to add a comment