New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793031 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 767683
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Network.setExtraHTTPHeaders no longer adds headers to initial navigation request

Project Member Reported by pmeenan@chromium.org, Dec 7 2017

Issue description

Looks like 63 introduced a bug where the Chrome remote debug protocol Network.setExtraHTTPHeaders is no longer adding the headers to the initial navigation request.  My guess is that it is because of plznavigate and the navigation request being initiated from the browser and not the renderer.

For example, this webpagetest test: https://www.webpagetest.org/result/171207_1H_647bfdafac28e369757b0b6837595fe1/

adds a custom header "x-Bob: CustomHeaderHere" by sending the message:

{"params":{"headers":{"x-Bob":"CustomHeaderHere"}},"id":9,"method":"Network.setExtraHTTPHeaders"}

Looking through the individual requests the header is applied to all of the requests except for the first navigation request.

Remote debug protocol spec:

https://chromedevtools.github.io/devtools-protocol/tot/Network/#method-setExtraHTTPHeaders

 
Passing --disable-browser-side-navigation as a command-line option fixes the issue so it very-much looks like an interaction with plznavigate.

https://www.webpagetest.org/result/171207_56_f575271b3c8f6fd94088c950d07b2cb6/
Cc: arthurso...@chromium.org

Comment 3 by jam@chromium.org, Dec 7 2017

Cc: clamy@chromium.org ahemery@chromium.org nasko@chromium.org pfeldman@chromium.org
Labels: -Pri-3 Proj-PlzNavigate Pri-2

Comment 4 by jam@chromium.org, Dec 7 2017

Note --disable-browser-side-navigation is going away next week as we start removing the old navigation code path (which is unsupported with Chrome at this point).
Owner: caseq@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by caseq@chromium.org, Dec 8 2017

Mergedinto: 767683
Status: Duplicate (was: Assigned)
This is already fixed in m64 (see  issue 767683  for details)

Sign in to add a comment