Confusion for scale factor in site_per_process_browsertests |
|
Issue descriptionIt seems that there is a missing scale_factor somewhere in the test or plumbing it in to Blink that hittesting API fails. This needs some investigation.
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b commit bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Mon Jan 08 14:46:38 2018 oopif events: Fix a couple of issues with async event targeting. . The renderer already applies the device-scale-factor during hit-test. So avoid doing any scaling on the browser side. . When querying a nested client for targeting, make sure the location is correctly transformed to that view's coordinate space. BUG= 797661 , 793018 Change-Id: I65d74ad49fb25d1a9cb05745e2a2f8d3ac26763e Reviewed-on: https://chromium-review.googlesource.com/848033 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#527632} [modify] https://crrev.com/bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b/content/browser/renderer_host/render_widget_targeter.cc [modify] https://crrev.com/bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b/content/browser/site_per_process_browsertest.cc [add] https://crrev.com/bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b/content/test/data/frame_tree/page_with_content_overlap_positioned_frame.html [modify] https://crrev.com/bc55716b7ce8d4a19eea2b4b9d62bf4ad72e7a6b/testing/buildbot/filters/viz.content_browsertests.filter |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jan 8 2018