New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793016 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

moblab-vm: Support SSP

Project Member Reported by pprabhu@chromium.org, Dec 7 2017

Issue description

Currently, moblab-vm can not run tests with SSP.

There are a few problems with this.

First virt-what isn't installed, so moblab-vm doesn't realize it is in a VM:
12/05 17:20:51.155 WARNI|             utils:2300| Package virt-what is not installed, default to assume it is not a virtual machine.

Second, lxc-clone takes too long:
12/05 17:20:51.156 DEBUG|             utils:0212| Running 'sudo lxc-clone --lxcpath /mnt/moblab/containers --newpath /mnt/moblab/containers --orig base_05 --new test_2_1512523250_26622  '
12/05 17:57:43.515 DEBUG|             utils:0212| Running 'sudo mv /tmp/tmpHNGh9b /mnt/moblab/containers/test_2_1512523250_26622/container_id.p'

(that's 37 minutes for a single clone)

Third, lxc-attach fails:

12/05 18:01:31.633 DEBUG|             utils:0212| Running 'sudo lxc-attach -P /mnt/moblab/containers -n test_2_1512523250_26622 -- bash -c "curl --head http://storage.googleapis.com/abci-ssp/
autotest-containers/base_05.tar.xz"'
12/05 18:02:12.312 DEBUG|         container:0304| Command <sudo lxc-attach -P /mnt/moblab/containers -n test_2_1512523250_26622 -- bash -c "curl --head http://storage.googleapis.com/abci-ssp/
autotest-containers/base_05.tar.xz"> failed, rc=6, Command returned non-zero exit status
* Command: 
    sudo lxc-attach -P /mnt/moblab/containers -n test_2_1512523250_26622 --
    bash -c "curl --head http://storage.googleapis.com/abci-ssp/autotest-
    containers/base_05.tar.xz"
Exit status: 6
Duration: 40.6738729477

stderr:
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M  0     0    0     0    0    
 0      0      0 --:--:--  0:00:01 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00
:03 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0^M  0     0  
  0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:07 --:--:--     0^M  0     0    0     0    0     0      0    
  0 --:--:--  0:00:08 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:09 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:10 --:--:-- 
    0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:11 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:12 --:--:--     0^M  0     0    0     0    
0     0      0      0 --:--:--  0:00:13 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:14 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:-- 
 0:00:15 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:16 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:17 --:--:--     0^M  0   
  0    0     0    0     0      0      0 --:--:--  0:00:18 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:19 --:--:--     0^M  0     0    0     0    0     0      
0      0 --:--:--  0:00:20 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:21 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:22 --:-
-:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:23 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:24 --:--:--     0^M  0     0    0     
0    0     0      0      0 --:--:--  0:00:25 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:26 --:--:--     0^M  0     0    0     0    0     0      0      0 --:-
-:--  0:00:27 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:28 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:29 --:--:--     0^M 
 0     0    0     0    0     0      0      0 --:--:--  0:00:30 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:31 --:--:--     0^M  0     0    0     0    0     0 
     0      0 --:--:--  0:00:32 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:33 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:34
 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:35 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:36 --:--:--     0^M  0     0    0
     0    0     0      0      0 --:--:--  0:00:37 --:--:--     0^M  0     0    0     0    0     0      0      0 --:--:--  0:00:38 --:--:--     0^M  0     0    0     0    0     0      0      0
 --:--:--  0:00:39 --:--:--     0curl: (6) Could not resolve host: storage.googleapis.com

 
I'm going to start by skipping SSP tests in moblab-vm. It still gets us some coverage.

dshi: What are the known problems with using SSP inside a VM. Is that even possible?

Comment 2 by dshi@chromium.org, Dec 7 2017

Cc: sbasi@chromium.org
+sbasi

I vaguely remember Simran did some research on this a while ago.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/80f79d1c3dedfd142e53c44639058f19ac07d6d7

commit 80f79d1c3dedfd142e53c44639058f19ac07d6d7
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 12 21:50:55 2017

cbuildbot: Restrict moblab VM tests to non-ssp tests.

BUG=chromium:725620
BUG=chromium:793016
TEST=moblab-vm-test

Change-Id: Iaa2c0ce803a3b73bf28da4226c1c6631de13e125
Reviewed-on: https://chromium-review.googlesource.com/816062
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/80f79d1c3dedfd142e53c44639058f19ac07d6d7/cbuildbot/stages/vm_test_stages.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bd54287ed0da68c7b7f835b866114571a80cada0

commit bd54287ed0da68c7b7f835b866114571a80cada0
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Dec 12 21:51:04 2017

Add a minimal server side test suite excluding SSP.

We do not support SSP in moblab-generic-vm yet. The minimal dummy_server
suite runs dummy_PassServer thrice -- with SSP, without SSP and maybe
with SSP. This is wasteful in the case when we don't support SSP at all.
So create an even simpler suite with just the nossp version of the test.

We still want to run it via a suite, so that we test the dynamic_suites
logic.

BUG=chromium:793016
TEST=moblab-vm-tests.

Change-Id: I803076f11091fd5920e422de80d83a95d3ca3879
Reviewed-on: https://chromium-review.googlesource.com/815134
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[add] https://crrev.com/bd54287ed0da68c7b7f835b866114571a80cada0/test_suites/control.dummy_server_nossp
[add] https://crrev.com/bd54287ed0da68c7b7f835b866114571a80cada0/server/site_tests/moblab_RunSuite/control.dummyServerNoSsp
[modify] https://crrev.com/bd54287ed0da68c7b7f835b866114571a80cada0/site_utils/attribute_whitelist.txt
[modify] https://crrev.com/bd54287ed0da68c7b7f835b866114571a80cada0/server/site_tests/dummy_PassServer/control.nossp

Comment 5 by jkop@chromium.org, Mar 15 2018

Status: Started (was: Untriaged)
Components: Infra>Client>ChromeOS>CI
Components: -Infra>Client>ChromeOS
Owner: ----
Status: Untriaged (was: Started)
There is no plan currently to add SSP support to moblabVM.

Sign in to add a comment