New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 793015 link

Starred by 1 user
Status: Fixed
Owner:
█ wnwen@chromium.org
OOO until Feb 4th
Closed: Dec 2017
Cc:
agrieve@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 793014



Sign in to add a comment

Supersize should display/record compress sizes for pak symbols

Project Member Reported by wnwen@chromium.org, Dec 7 2017 
It's more useful to have accurate estimates of compressed sizes than uncompressed sizes in order to make meaningful comparisons in size costs for assets vs native library vs dex.

Use compression ratio to calculate estimates for compressed sizes of pak symbols. Eventually if we think uncompressed sizes is useful we might store that in metadata, but that is outside the scope of this bug.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/362c2549195c0565a72c1a4960b0937191a7d9ad

commit 362c2549195c0565a72c1a4960b0937191a7d9ad
Author: Peter Wen <wnwen@chromium.org>
Date: Tue Dec 12 18:20:12 2017

Supersize: Track compressed sizes for pak symbols

Switch to tracking estimated compressed sizes for pak symbols as this
has a bigger impact to our apk size. Eventually we want to be able to
attribute every byte in our apk.

BUG= 793015 

Change-Id: I7a91c71a5d21f821c70aefcce6bffb2978ff157e
Reviewed-on: https://chromium-review.googlesource.com/822890
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523480}
[modify] https://crrev.com/362c2549195c0565a72c1a4960b0937191a7d9ad/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/362c2549195c0565a72c1a4960b0937191a7d9ad/tools/binary_size/libsupersize/testdata/Archive_Pak.golden

Comment 2 by wnwen@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment