New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 793014 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocked on:
issue 793015



Sign in to add a comment

Track all files in apk

Project Member Reported by wnwen@chromium.org, Dec 7 2017

Issue description

Supersize should output a list of sections with sizes and corresponding symbols such that the total size is exactly the size of the *.apk.

All non-analyzed files can go into .other for now.
 

Comment 1 by wnwen@chromium.org, Dec 7 2017

Blockedon: 793015
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155562d0f111bd21e4a74a8361281e0ca5c87567

commit 155562d0f111bd21e4a74a8361281e0ca5c87567
Author: Peter Wen <wnwen@chromium.org>
Date: Mon Dec 11 15:24:32 2017

Supersize: Track all other files in apks

Currently .so and .pak files are parsed and tracked. Group all other
files in .other section for now so we at least track them too.

Bug:  793014 
Change-Id: I7237c0e329e9e6b06ec08ff15d3b5395f56a65e7
Reviewed-on: https://chromium-review.googlesource.com/815357
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523098}
[modify] https://crrev.com/155562d0f111bd21e4a74a8361281e0ca5c87567/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/155562d0f111bd21e4a74a8361281e0ca5c87567/tools/binary_size/libsupersize/models.py

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf

commit 20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf
Author: Peter Wen <wnwen@chromium.org>
Date: Thu Dec 21 18:21:35 2017

Supersize: Add overhead symbols

The apk (zip) file and ELF native library have overheads from their file
structure. Add these to be tracked for increases/decreases and so that
the total of all the section sizes is exactly the apk file size on disk.

BUG= 793014 

Change-Id: Ided840bd812c75a6bb00fd91bd88ed9d58379e11
Reviewed-on: https://chromium-review.googlesource.com/837461
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525741}
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/archive.py
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/integration_test.py
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/Archive_Elf.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/Archive_Pak.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/Console.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/Csv.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/Diff_NullDiff.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/FullDescription.golden
[modify] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/SymbolGroupMethods.golden
[rename] https://crrev.com/20dc22253e0bac8e4b5ae9fc7a805a649a4a96cf/tools/binary_size/libsupersize/testdata/mock_output_directory/elf.begin

Comment 4 by wnwen@chromium.org, Dec 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bbfe472e8c34e6023f1eb404377d7e7371e2154

commit 2bbfe472e8c34e6023f1eb404377d7e7371e2154
Author: Andrew Grieve <agrieve@chromium.org>
Date: Thu Jan 04 17:02:18 2018

Supersize: Add pak and other support to html_report

Other html_report tweaks:
  * Changes --include-symbols to --symbol-size-threshold
    * This is useful because it's nice to see the actual symbol
      names for pak files (and other large symbols)
  * Hides .other symbols by default (since they are exist at /)
    * But they can be shown via "options" in the UI
  * Adds a ?sections= query parameter so you can link to a
    chart with just certain sections.

Also:
  * Adds SymbolGroup.WhereIsPak() and WhereIsNative()
  * Adds canned_query.PakByPath()
  * Adds models.BaseSizeInfo
    * Which has: .symbols, .native_symbols, .pak_symbols

Bug:  723672 ,  793014 
Change-Id: Ia054826a1d52240deb979834b45db940e956b716
Reviewed-on: https://chromium-review.googlesource.com/849315
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527016}
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/canned_queries.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/describe.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/diff.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/html_report.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/integration_test.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/models.py
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/template/D3SymbolTreeMap.js
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/template/index.html
[modify] https://crrev.com/2bbfe472e8c34e6023f1eb404377d7e7371e2154/tools/binary_size/libsupersize/testdata/Console.golden

Sign in to add a comment