Fail build if lint encounters unexpected failure |
|||||
Issue description
These failures are showing up again (building release monochrome_public_apk)
Let's fail the build if these are introduced.
Unexpected failure during lint analysis of ContextualSearchPolicy.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of UsbChooserPreferences.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of UsbDevicePreferences.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of SingleCategoryPreferences.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of BottomToolbarPhone.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of DownloadManagerUi.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of ChromeContextMenuPopulator.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of IncognitoBottomSheetContent.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of UrlUtilities.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of CreateRouteRequest.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761) Unexpected failure during lint analysis of CastSessionImpl.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of PlaceholderSheetContent.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
Unexpected failure during lint analysis of FloatLabelLayout.java (this is a bug in lint or one of the libraries it depends on)
AbortCompilation:ProblemHandler.handle(ProblemHandler.java:159)<-ProblemHandler.handle(ProblemHandler.java:226)<-ProblemReporter.handle(ProblemReporter.java:2393)<-ProblemReporter.isClassPathCorrect(ProblemReporter.java:4761)
[30324/30324] STAMP obj/chrome/android/monochrome_public_apk.stamp
,
Dec 21 2017
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c93e3daf6e20b08dc1559668cd953503226cfcb4 commit c93e3daf6e20b08dc1559668cd953503226cfcb4 Author: Peter Wen <wnwen@chromium.org> Date: Thu Dec 21 23:57:08 2017 Android: Add flag to fail build on lint failure Currently lint can fail with "Unexpected failure..." and log that to stderr but the build can still pass. This has resulted in many lint errors creeping in as lint stops processing after encountering one of these failures. Add a flag so that when this wave of "Unexpected failure..." errors are resolved, we can turn on the flag to fail future builds if they introduce these failures. BUG= 793007 Change-Id: I7c98ed36d379b2dbd079cc5f74b60c03e033444b Reviewed-on: https://chromium-review.googlesource.com/840822 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#525862} [modify] https://crrev.com/c93e3daf6e20b08dc1559668cd953503226cfcb4/build/android/gyp/lint.py [modify] https://crrev.com/c93e3daf6e20b08dc1559668cd953503226cfcb4/build/config/android/internal_rules.gni
,
Dec 28 2017
How must the sheriffs handle this? Is there a known culprit of these failures?
,
Dec 28 2017
These types of lint failures shouldn't be causing build failures, if they are could you post a link to the bot where this is happening and/or repro steps (gn args, stack trace)?
,
Dec 28 2017
Sorry, I might have misinterpreted the previous comments. I saw similar errors here: https://uberchromegw.corp.google.com/i/chromium/builders/Android/builds/80034 and thought they could've caused the failures.
,
Dec 28 2017
#6: that's probably a hang in APK finalization and is not related to this issue.
,
Dec 28 2017
#7: Ok, thanks for clarifying!
,
Jan 3 2018
,
Jan 4 2018
Seems like these are caused by tools-lint/bin/lint still on 25.3.2 whereas tools/bin/lint is already on 26.0.0+. Fixing the blocking bug should resolve most if not all these errors, then we can turn this flag on.
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fda404f68e955fc94c490d74d1efef7c5a42625e commit fda404f68e955fc94c490d74d1efef7c5a42625e Author: Peter Wen <wnwen@chromium.org> Date: Mon Jan 15 18:30:34 2018 Android: Fail build on lint unexpected Previously lint silently passed when it crashes while linting a file. This allows many failures to be added between lint upgrades/fixes. Prevent it by failing lint on any unexpected failure messages. Bug: 793007 Change-Id: I7c4bc6fd0f6ceee2e52ff16f20457a0e8ccd84f8 Reviewed-on: https://chromium-review.googlesource.com/860485 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#529312} [modify] https://crrev.com/fda404f68e955fc94c490d74d1efef7c5a42625e/build/config/android/internal_rules.gni
,
Jan 17 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wnwen@chromium.org
, Dec 7 2017