New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792999 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

arm debug info is reaching elf32 4GB limit

Project Member Reported by yunlian@chromium.org, Dec 7 2017

Issue description

On latest elf build. I have
~/Downloads/debug/opt/google/chrome$ ls -l chrome.dwp 
-rw-r----- 1 yunlian eng 4250482188 Dec  7 05:40 chrome.dwp

It is a elf 32 file. And the 4GB limit is
4294967296

So we are pretty close to this limit and we need to find a workaround for
it/
 
Cc: llozano@chromium.org
Labels: -Pri-2 Pri-1
Raising priority to p1 because the from the latest build, the chrome.dwp execeeds the 4GB limit.
Components: Infra
Cc: vapier@chromium.org ivanpe@chromium.org
As a workaround, we want to set remove_webcore_debug_symbols=true in release buidls for arm.

Comment 5 by mmoss@chromium.org, Jan 2 2018

Components: -Infra Infra>Client>ChromeOS
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3397e4422cf8d81c6d4587fa2d71e1ade65c9c4a

commit 3397e4422cf8d81c6d4587fa2d71e1ade65c9c4a
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Tue Jan 02 23:48:25 2018

keep webcore debug symbols for simple chrome.

We want to keep the webcore debug symbols for arm even we remove it
in release builds.

BUG= chromium:792999 
TEST=remove_webcore_debug_symbols is set to False.

Change-Id: I5e89485aa61f41d285e08b364a6be1b872b86b58
Reviewed-on: https://chromium-review.googlesource.com/845124
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3397e4422cf8d81c6d4587fa2d71e1ade65c9c4a/cli/cros/cros_chrome_sdk.py

Cc: akes...@chromium.org
Owner: snanda@chromium.org
Status: Assigned (was: Untriaged)
This is listed as a CrOS Infra problem, but the CrOS Infra team
is likely poorly placed to solve this, and really, I think this
is a product problem.

Passing to snanda@ in hopes he can find a better owner.

Components: -Infra>Client>ChromeOS
Owner: laszio@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/69b4929c99bac77e22a5c84598686d49a483e732

commit 69b4929c99bac77e22a5c84598686d49a483e732
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Sat Jan 06 00:42:52 2018

chromeos-chrome: remove webcore debug symbols on arm.

The size limit of elf32 is 4GB, and the size of .dwp has exceeded this
limit. As a result, the .dwp is corrupt and we could not get any symbols
from it. This CL removes the debug symbols of webcore as a workaround
and we need to fix this in other ways.

BUG= chromium:792999 
TEST=the new .dwp file is 2.8 GB.

Change-Id: I567e0fd90ac806630d2f6e1e7281cd2ef072553f
Reviewed-on: https://chromium-review.googlesource.com/845116
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/69b4929c99bac77e22a5c84598686d49a483e732/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Owner: yunlian@chromium.org
Yunlian is working on this.
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa5f218fef824ccc58f3b3e81402ec8915544665

commit aa5f218fef824ccc58f3b3e81402ec8915544665
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Mon Jan 29 19:36:21 2018

Webkit: keep minimal symbols when remove_webcore_debug_symbols is set.

We want to keep minimal symbols when remove_webcore_debug_symbols is
set, so that we can get readable backtrace.

On ChromeOS arm build, the size of debug file increases from
899MB to 1.244GB. It increases 245 MB.

Bug:  chromium:792999 
Change-Id: Ibc238308754a2727505cfbac3ce24f7a70027529
Reviewed-on: https://chromium-review.googlesource.com/862607
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532545}
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/config.gni
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/core/core.gni
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/modules/modules.gni
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/aa5f218fef824ccc58f3b3e81402ec8915544665/third_party/WebKit/Source/platform/wtf/BUILD.gn

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/75fc9e57904dfce30ab79eeb967b2a9deea927e2

commit 75fc9e57904dfce30ab79eeb967b2a9deea927e2
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Thu Feb 01 06:39:03 2018

chrome_sdk: Keep debug symbols for webcore on simple chrome.

We plan to use another gn parameter in the ebuild to reduce the
size of debug files of webcore on arm. So we need to override
the option to make simple chrome unaffected.

BUG= chromium:792999 
TEST=simple chrome works with this change.

Change-Id: I4a9ad4530f10fccd2ffe4b3fc5eafbe682a9f96c
Reviewed-on: https://chromium-review.googlesource.com/894175
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/75fc9e57904dfce30ab79eeb967b2a9deea927e2/cli/cros/cros_chrome_sdk.py

Components: Tools>ChromeOS-Toolchain
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3939a65c9a874fad2096ebd3e2ac6d7045f0e579

commit 3939a65c9a874fad2096ebd3e2ac6d7045f0e579
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Thu Feb 08 09:23:56 2018

chromeos-chrome: the blink_symbol_level=1 for arm builds.

This sets the blink_symbol_level=1 so that ideally we can use
-g1 to build webcore to get valid stack trace.

BUG= chromium:792999 
TEST=emerge-kevin chromeos-chrome

Change-Id: Id4a247c3a452024518a8aa807902084e18f0e3b1
Reviewed-on: https://chromium-review.googlesource.com/905406
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/3939a65c9a874fad2096ebd3e2ac6d7045f0e579/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Labels: Merge-Request-65
R65 may need the changes otherwise there is no valid stack trace of webcore on arm.
Project Member

Comment 16 by sheriffbot@chromium.org, Feb 8 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: M65 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 18 by sheriffbot@chromium.org, Feb 13 2018

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 19 by sheriffbot@chromium.org, Feb 16 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Apr 2 2018

Labels: -Merge-Approved-65
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Verified (was: Assigned)

Sign in to add a comment