Reporting / Network Error Logging: Fix shutdown cyclical dependency issues |
|||
Issue descriptionRight now, when Reporting shuts down and terminates pending uploads, NEL can generate an error report and call in to the half-destructed ReportingService, which breaks things. I should make sure that Reporting and NEL are torn down in the right order (NEL first, then Reporting), and consider explicitly breaking dependencies to be extra sure.
,
Dec 7 2017
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65eb67f2a1809170456d58bb0a77feb991ec6fd5 commit 65eb67f2a1809170456d58bb0a77feb991ec6fd5 Author: Julia Tuttle <juliatuttle@chromium.org> Date: Fri Dec 08 20:44:02 2017 NEL: Destroy before Reporting to avoid reentrancy and crash Right now, the ReportingService is manually destroyed in ~ContainerURLRequestContext, which can generate network errors that NEL will then try to report using the half-destroyed ReportingService. Fix this improper destruction order by first tearing down NEL manually as well. (This will be tested in a later end-to-end test, which will more easily have the resources to exercise Reporting and NEL.) Bug: 792978 Change-Id: I00822bf64db5e2033c71da33b8a572b693c37acf Reviewed-on: https://chromium-review.googlesource.com/814840 Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#522865} [modify] https://crrev.com/65eb67f2a1809170456d58bb0a77feb991ec6fd5/net/url_request/url_request_context_builder.cc
,
Dec 8 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by juliatut...@chromium.org
, Dec 7 2017