New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Changed value of flags descriptions on chrome://interventions-internals.

Project Member Reported by thanhdle@chromium.org, Dec 7 2017

Issue description

Features can be enabled through Finch, which essentially having the same effect that changing the flags on chrome://flags. Using "Forced Enabled/Disabled" can be confusing.

Changing them to "Enabled/Disabled/Default" provide the status of the feature, and the link to the flag that can override that behavior.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e39107d2d90d21e659c377e7b05599fa2957f79b

commit e39107d2d90d21e659c377e7b05599fa2957f79b
Author: Thanh Le <thanhdle@chromium.org>
Date: Thu Dec 07 18:43:06 2017

Changed value of flags descriptions on chrome://interventions-internals.

Features can be enabled through Finch, which essentially having the same
effect that changing the flags on chrome://flags. Using "Forced
Enabled/Disabled" can be confusing.

Changing them to "Enabled/Disabled/Default" provide the status of the
feature, and the link to the flag that can override that behavior.

Bug:  792977 
Change-Id: Icb44112fa32b3147ff46ab6aa82710cfaa331894
Reviewed-on: https://chromium-review.googlesource.com/814775
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522488}
[modify] https://crrev.com/e39107d2d90d21e659c377e7b05599fa2957f79b/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.cc
[modify] https://crrev.com/e39107d2d90d21e659c377e7b05599fa2957f79b/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment