Network Error Logging: Fix crash in URLRequest. |
||||
Issue descriptionRight now, if NEL is enabled, it crashes on requests with no response headers because it unconditionally calls URLRequest::GetResponseCode. I should fix this.
,
Dec 7 2017
,
Dec 7 2017
,
Dec 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7005a2a9e1910ed05362990cddc5be7973719e32 commit 7005a2a9e1910ed05362990cddc5be7973719e32 Author: Julia Tuttle <juliatuttle@chromium.org> Date: Fri Dec 08 21:01:18 2017 NEL: Don't crash on failed requests without response headers Make sure we have response headers before trying to get the response code. Also, add a unittest that uses an EmbeddedTestServer to make sure we're exercising the interaction with URLRequestHttpJob. Also also, convert some related Bind calls to BindRepeating. Bug: 792971 Change-Id: I4e7dcde3526f137af032bc44b41bac085e201715 Reviewed-on: https://chromium-review.googlesource.com/814837 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by: Miriam Gershenson <mgersh@chromium.org> Cr-Commit-Position: refs/heads/master@{#522873} [modify] https://crrev.com/7005a2a9e1910ed05362990cddc5be7973719e32/net/url_request/url_request.cc [modify] https://crrev.com/7005a2a9e1910ed05362990cddc5be7973719e32/net/url_request/url_request_unittest.cc
,
Dec 8 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by juliatut...@chromium.org
, Dec 7 2017