New issue
Advanced search Search tips

Issue 792968 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 497851



Sign in to add a comment

Rename scroll-snap-margin to scroll-margin

Project Member Reported by sunyunjia@chromium.org, Dec 7 2017

Issue description

As changed in spec, we should rename scroll-snap-margin to scroll-margin.

https://drafts.csswg.org/css-scroll-snap-1/#changes-20170824
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d3134426aaa0499424fcf363552bc6a4f037145

commit 0d3134426aaa0499424fcf363552bc6a4f037145
Author: Sandra Sun <sunyunjia@chromium.org>
Date: Fri Jan 12 14:08:25 2018

Rename CSS scroll-snap-margin to scroll-margin

The name change was decided here:
https://drafts.csswg.org/css-scroll-snap-1/#changes-20170824

Bug:  792968 
Change-Id: Ic339d11bac81b7114a042e0b662c12056efaf555
Reviewed-on: https://chromium-review.googlesource.com/861910
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528935}
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/LayoutTests/css-parser/snap-points-parsing.html
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/BUILD.gn
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/StylePropertySerializer.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/css.dict
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/parser/CSS.proto
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/parser/CSSProtoConverter.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginBlockEndCustom.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginBlockStartCustom.cpp
[copy] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginBottomCustom.cpp
[copy] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginInlineEndCustom.cpp
[copy] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginInlineStartCustom.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginLeftCustom.cpp
[copy] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginRightCustom.cpp
[copy] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/longhands/ScrollMarginTopCustom.cpp
[delete] https://crrev.com/2e4eab147b94a947ed4650234637b85802000b2b/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginBottomCustom.cpp
[delete] https://crrev.com/2e4eab147b94a947ed4650234637b85802000b2b/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginInlineEndCustom.cpp
[delete] https://crrev.com/2e4eab147b94a947ed4650234637b85802000b2b/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginInlineStartCustom.cpp
[delete] https://crrev.com/2e4eab147b94a947ed4650234637b85802000b2b/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginLeftCustom.cpp
[delete] https://crrev.com/2e4eab147b94a947ed4650234637b85802000b2b/third_party/WebKit/Source/core/css/properties/longhands/ScrollSnapMarginRightCustom.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/shorthands/ScrollMarginBlockCustom.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/shorthands/ScrollMarginCustom.cpp
[rename] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/css/properties/shorthands/ScrollMarginInlineCustom.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/frame/UseCounter.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/page/scrolling/SnapCoordinatorTest.cpp
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/third_party/WebKit/Source/core/style/ComputedStyle.h
[modify] https://crrev.com/0d3134426aaa0499424fcf363552bc6a4f037145/tools/metrics/histograms/enums.xml

Status: Fixed (was: Untriaged)
Blocking: 497851

Sign in to add a comment