Issue metadata
Sign in to add a comment
|
PageInfo does not display tooltips |
||||||||||||||||||||||||
Issue descriptionChrome Version: 65.3286 on Mac and Windows What steps will reproduce the problem? (1) Visit https://example.com (2) Click the Lock to Open Page Info (3) Hover over the "Certificate (valid)" button Expect: Certificate issuer shows in tooltip Actual: No tooltip
,
Dec 12 2017
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2790c0050bcaf56508992c738f7ccd1da7ac4935 commit 2790c0050bcaf56508992c738f7ccd1da7ac4935 Author: Patti <patricialor@chromium.org> Date: Mon Jan 08 23:31:40 2018 Desktop Page Info/Views: Allow custom tooltips on HoverButtons if required. HoverButtons currently set their own tooltips based on the whether the text contained in its |title_| and |subtitle_| have enough space to show. These update every time the title text changes or the view bounds change, so they overwrite any custom tooltips set by callers. Fix by adding a flag to turn auto-tooltips off. Bug: 792962 Change-Id: I4a99bbfe76d716295249f670f017ff07349e90e1 Reviewed-on: https://chromium-review.googlesource.com/838725 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#527809} [modify] https://crrev.com/2790c0050bcaf56508992c738f7ccd1da7ac4935/chrome/browser/ui/views/hover_button.cc [modify] https://crrev.com/2790c0050bcaf56508992c738f7ccd1da7ac4935/chrome/browser/ui/views/hover_button.h [add] https://crrev.com/2790c0050bcaf56508992c738f7ccd1da7ac4935/chrome/browser/ui/views/hover_button_unittest.cc [modify] https://crrev.com/2790c0050bcaf56508992c738f7ccd1da7ac4935/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/2790c0050bcaf56508992c738f7ccd1da7ac4935/chrome/test/BUILD.gn
,
Jan 8 2018
,
Feb 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed21e9a0bc1bee52b16d3dc30d1bab71365b9805 commit ed21e9a0bc1bee52b16d3dc30d1bab71365b9805 Author: Patti <patricialor@chromium.org> Date: Thu Feb 08 01:49:58 2018 Desktop Page Info: Only allow custom tooltips on the certificate button. r527809 allowed HoverButtons used in the Page Info bubble to set their own tooltips, overriding the default HoverButton behavior, which computes a tooltip automatically if the text cannot fit into the space available. However, this changed it for the cookies button as well, which was not required (only the certificate button has a custom tooltip). Fix by setting the flag on the certificate button only and not the cookies button. Manually test by changing Chrome to run in Russian (e.g. LANGUAGE="ru" ./chrome) then navigate to https://nytimes.com/ and open the Page Info bubble. Note the string in the cookies button is cut off. Hover over it to see that the full text is shown in the tooltip that appears. Bug: 792962 Change-Id: If2d547643bca2e63388d44c41244f1cde6762d9e Reviewed-on: https://chromium-review.googlesource.com/905247 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#535246} [modify] https://crrev.com/ed21e9a0bc1bee52b16d3dc30d1bab71365b9805/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
,
Feb 8 2018
Verified the fix on Windows 10, Mac 10.12.6, Ubuntu 14.04 on Chrome version #66.0.3343.0 as per the comment#5 Attaching screen shot for reference. Observed "Certificate issuer shows in tooltip" Hence, the fix is working as expected. Adding the verified labels. Thanks!
,
Feb 8 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jialiul@chromium.org
, Dec 12 2017Status: Available (was: Untriaged)