New issue
Advanced search Search tips

Issue 792959 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Dec 2017
Cc:
stkhapugin@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

If the omnibox is focused too quickly after opening an incognito tab, the focused is lost

Project Member Reported by gambard@chromium.org, Dec 7 2017 
What steps will reproduce the problem?
(1) Open a new incognito tab
(2) Tab the omnibox before the end of the animation

What is the expected result?
The omnibox should be focused

What happens instead?
The omnibox focus is lost. You have to tap again the omnibox to focus it
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6439690d75e627eba9e69aef1c80c933b12237ad

commit 6439690d75e627eba9e69aef1c80c933b12237ad
Author: Gauthier Ambard <gambard@chromium.org>
Date: Fri Dec 08 10:14:58 2017

Do not notify the toolbar of new opened tab

The toolbar does not need to be notified when a new tab is opened.
This notification arrives at the end of the new tab opening animation,
at which point the user might have started to interact with the toolbar.

Bug:  792959 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2774bfba5207c1d250837522c4b8e73177943c17
Reviewed-on: https://chromium-review.googlesource.com/814556
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522751}
[modify] https://crrev.com/6439690d75e627eba9e69aef1c80c933b12237ad/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/6439690d75e627eba9e69aef1c80c933b12237ad/ios/chrome/browser/ui/browser_view_controller_unittest.mm

Comment 2 by gambard@chromium.org, Dec 8 2017

Status: Fixed (was: Assigned)

Comment 3 by vbarig...@chromium.org, Dec 12 2017

Status: Verified (was: Fixed)
Verified on chrome canary version 65.0.3292.0 on iPhone 8 plus 11.2 beta 6 , iPhone 7 plus 10.3.3, following the steps mentioned in comment #0.  Omnibox is focused in new incognito tab.  Looks good.
►

Sign in to add a comment