New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 792952 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Dec 2017
Cc:
█ junov@chromium.org
█ xlai@chromium.org
npm@chromium.org
█ imch...@chromium.org
hbos@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

8.6%-26.1% regression in thread_times.tough_scrolling_cases at 521782:521956

Project Member Reported by npm@chromium.org, Dec 7 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 7 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792952

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=4ee961a5195aa45e239a74b8728b1e79e816a38460a745f6cb070f273a51d060


Bot(s) for this bug's original alert(s):

chromium-rel-mac12
chromium-rel-mac12-mini-8gb
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 7 2017

Cc: xlai@chromium.org imch...@chromium.org hbos@chromium.org junov@chromium.org
Owner: imch...@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14dee0d4040000

Move TransferableResource creation to Canvas Resource
By junov@chromium.org · Tue Dec 05 22:44:49 2017
chromium @ 4f6bce25c2f94e59611343ddab1fffcc13f79f07

Revert "Run constraints processing for screen capture on the main thread."
By imcheng@chromium.org · Tue Dec 05 22:47:09 2017
chromium @ 363560ef6a40f1113a1440da53fc0fcb20de40e2

Revert "Revert "Run constraints processing for screen capture on the main thread.""
By imcheng@chromium.org · Tue Dec 05 23:20:28 2017
chromium @ f28f29f4bc751439a347c129a3b6ba5a43980d66

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by imch...@chromium.org, Dec 12 2017

Owner: junov@chromium.org
My patches were reverts and should have no net effect. junov@, could you PTAL if it could be related to your patch?

Comment 5 by junov@chromium.org, Dec 13 2017 

 Issue 792951  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec6125cd13b1850ece40029cff8c4504db7f7c43

commit ec6125cd13b1850ece40029cff8c4504db7f7c43
Author: Justin Novosad <junov@chromium.org>
Date: Wed Dec 13 22:33:29 2017

Re-enable overlays for 2d canvas

In this refactor CL:
https://crrev.com/4f6bce25c2f94e59611343ddab1fffcc13f79f07
overlays got disabled by accident, causing performance regressions
on mac.

BUG= 792952 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8acdd0f9157ab4fb31c5cfe62366387cdae7a4ca
Reviewed-on: https://chromium-review.googlesource.com/825702
Reviewed-by: Olivia Lai <xlai@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523917}
[modify] https://crrev.com/ec6125cd13b1850ece40029cff8c4504db7f7c43/third_party/WebKit/Source/platform/graphics/CanvasResource.h

Comment 7 by junov@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
Fix confirmed.  Performance graphs have recovered.

Comment 8 by junov@chromium.org, Dec 14 2017 

 Issue 792944  has been merged into this issue.

Comment 9 by imch...@chromium.org, Jan 29 2018 

 Issue 792947  has been merged into this issue.

Comment 10 by imch...@chromium.org, Jan 29 2018 

 Issue 792949  has been merged into this issue.
►

Sign in to add a comment