New issue
Advanced search Search tips

Issue 792938 link

Starred by 1 user
Status: Duplicate
Merged: issue 792921
Owner:
herb@google.com
Closed: Jan 2018
Cc:
danakj@chromium.org
flackr@chromium.org
kinuko@chromium.org
npm@chromium.org
boliu@chromium.org
fmalita@chromium.org
yigu@chromium.org
erikc...@chromium.org
herb@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.7% regression in system_health.memory_desktop at 521690:521769

Project Member Reported by npm@chromium.org, Dec 7 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 7 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=792938

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=70f55b466c23dd7d87f47bf304841837619f7ba9ad212f2b0e371a48238c4f91


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Dec 7 2017

Cc: kinuko@chromium.org flackr@chromium.org yigu@chromium.org fmalita@chromium.org danakj@chromium.org herb@google.com boliu@chromium.org
Owner: herb@google.com
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/12a6b11c040000

Round the scroll offset synced back to main thread instead of flooring
By yigu@chromium.org · Tue Dec 05 15:49:54 2017
chromium @ a3ce2d3110a3f9177a41935daadd43ede72db553

Turn on new image blur for chrome. Try 2
By herb@google.com · Tue Dec 05 17:22:57 2017
chromium @ 28a0d01c71f955054d79c3ff530f13db522cfa68

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 4 by sullivan@chromium.org, Jan 22 2018

Cc: erikc...@chromium.org
herb, yigu: Bisect reproduces a ~1.5MiB jump at each of your CLs. Can you please take a look? You can get traces with full memory dumps by clicking either on the point in the perf dashboard, or by clicking on the values in pinpoint (see screenshot attached).

+erikchen, who owns desktop memory benchmarks
pinpoint-traces.png
177 KB View Download

Comment 5 by yigu@chromium.org, Jan 22 2018 

My patch does increase the memory consumption which is expected. See  issue 792921 .

herb@, please mark this bug as duplicate if you believe your patch is innocent.

Comment 6 by herb@google.com, Jan 22 2018

Mergedinto: 792921
Status: Duplicate (was: Assigned)
►

Sign in to add a comment