Add more tests regarding UKM with Incognito |
||||
Issue descriptionAlthough there is a test to ensure UKM gets disabled when an Incognito window gets opened, it only tests a single order of creating regular then creating incognito, then destroying them in the opposite order. Add tests to ensure that other orderings don't somehow cause UKM to be enabled.
,
Dec 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fa95577455b5fb5123f2f2a9e1e5fa140d3fe5b commit 6fa95577455b5fb5123f2f2a9e1e5fa140d3fe5b Author: Brian White <bcwhite@chromium.org> Date: Thu Dec 07 19:31:53 2017 Check UKM against more Incognito open/close. Bug: 792933 Change-Id: I47fc79cf8db3444b50e26ce92a6c6e81621f6016 Reviewed-on: https://chromium-review.googlesource.com/814834 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#522507} [modify] https://crrev.com/6fa95577455b5fb5123f2f2a9e1e5fa140d3fe5b/chrome/browser/metrics/ukm_browsertest.cc
,
Dec 7 2017
,
Dec 12 2017
Re-opening since we need the same coverage for iOS. Over to holte@.
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/861bfc28c666516e3d9ba50c75b62f0d49ca8710 commit 861bfc28c666516e3d9ba50c75b62f0d49ca8710 Author: Steven Holte <holte@chromium.org> Date: Thu Jan 18 19:52:30 2018 Update iOS incognito test to match non-iOS. Matching IncognitoPlusRegular test left for follow up. Bug: 792933 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f8fda2d4771e54c1ffba3508cfcbf448ffa9150 Reviewed-on: https://chromium-review.googlesource.com/872268 Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#530234} [modify] https://crrev.com/861bfc28c666516e3d9ba50c75b62f0d49ca8710/ios/chrome/browser/metrics/ukm_egtest.mm
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c8e55dc3535d96e26a378b424e11b79845a5924 commit 4c8e55dc3535d96e26a378b424e11b79845a5924 Author: Steven Holte <holte@chromium.org> Date: Thu Jan 25 02:07:56 2018 Implement UKM testIncognitoPlusRegular for iOS. BUG= 792933 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7934e5eab5759b9fc5d0d76ba03817931bfae03a Reviewed-on: https://chromium-review.googlesource.com/874782 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#531784} [modify] https://crrev.com/4c8e55dc3535d96e26a378b424e11b79845a5924/ios/chrome/browser/metrics/ukm_egtest.mm
,
Jan 25 2018
Android changes tracked in crbug/804451 |
||||
►
Sign in to add a comment |
||||
Comment 1 by bcwh...@chromium.org
, Dec 7 2017