When opening a new NTP the favicon tiles are grey |
|||||||
Issue descriptionWhat steps will reproduce the problem? (1) Open any page (2) Kill the app (3) Open back the app to the page opened in 1. (4) Open a NTP What is the expected result? The favicon of the most visited tiles, the images of the suggestions and the buttons of the toolbar should be visible during the animation. What happens instead? The favicons and images are grey, the toolbar is hidden. They appear when the animation is over. It can also be seen when opening the app while it is presented a NTP, but it is harder to spot.
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0afa75731f532f923ef6bed0feee3a6ccfde72ec commit 0afa75731f532f923ef6bed0feee3a6ccfde72ec Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 11 09:52:10 2017 Animate the NTP instead of a snapshot When opening a NTP a screenshot of the NTP is animated instead of the real NTP. The screenshot of the NTP is taken outside of the view hierarchy. This creates multiple problems: - The safe area insets have to be passed to the NTP before the snapshot is taken so it can adapt its layout. - The images of the elements in the NTP (Most Visited, suggestions...) are displayed asynchronously, so they are empty on the snapshot. In order to reduce the complexity on iPhone X and to have the images displayed, it is possible to display the real view instead of its snapshot. As side effects, the user can interact with the NTP during the animation and it is possible that it takes more computational ressources. Animation before this CL: https://drive.google.com/file/d/1ma2Q_fGsK3lRSCAL91MZ3mXCD_R_tYEn/view Animation with this CL: https://drive.google.com/file/d/1xHL2ANNPwtYEY0vffqVuCvEfhrVXl_4v/view Bug: 792918 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibeb74f9ca96130db49bcf082356b55e6cf8d4d9a Reviewed-on: https://chromium-review.googlesource.com/814295 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523067} [modify] https://crrev.com/0afa75731f532f923ef6bed0feee3a6ccfde72ec/ios/chrome/browser/ui/browser_view_controller.mm
,
Dec 11 2017
,
Dec 19 2017
Verified the issue on the build version 65.0.3299.0 canary tested on iPhone7+. mostvisisted tiles and omnibox are displayed on opening a newtab works fine. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by gambard@chromium.org
, Dec 11 2017