Local NTP: Logo doesn't get hidden when typing into the fakebox |
||
Issue descriptionOn the local NTP: Click fakebox. Type something. Expected: Text appears in Omnibox, logo and fakebox vanish. Actual: Fakebox vanishes, but logo stays. Probably due to one of the recent html/css changes for Doodles.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b917b30ad27e20793acad30f2a482e353737aa2 commit 4b917b30ad27e20793acad30f2a482e353737aa2 Author: Chris Pickel <sfiera@chromium.org> Date: Wed Dec 13 14:10:24 2017 Local NTP: hide logo when using fakebox visibility is used for logos to mark whether the default logo or a Doodle is visible, and to fade between them. Apparently, visibility: visible in a child overrides visibility: hidden in a parent. Adding opacity as well prevents the logo from being visible. Bug: 792914 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iddc9f4fa2cb9dec45b979fa332e830f4958db79c Reviewed-on: https://chromium-review.googlesource.com/817122 Commit-Queue: Chris Pickel <sfiera@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#523768} [modify] https://crrev.com/4b917b30ad27e20793acad30f2a482e353737aa2/chrome/browser/resources/local_ntp/local_ntp.css [modify] https://crrev.com/4b917b30ad27e20793acad30f2a482e353737aa2/chrome/test/data/local_ntp/test_utils.js
,
Dec 13 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mastiz@chromium.org
, Dec 12 2017