chrome://media-engagement can't be sorted by "isHigh" |
||||
Issue description
STR:
1. open chrome://media-engagement
2. (probably sorted by score)
3. press "Is High" to sort with this column's value
Expected result: updated sorted list
Actual value: list is cleared with a console error:
```
Uncaught Error: Assertion failed: Unsupported sort key: isHigh
at assert (chrome://resources/js/util.js:27:17)
at assertNotReached (chrome://resources/js/util.js:60:3)
at compareTableItem (chrome://media-engagement/media-engagement.js:84:3)
at info.sort (chrome://media-engagement/media-engagement.js:58:37)
at Array.sort (native)
at sortInfo (chrome://media-engagement/media-engagement.js:57:8)
at renderTable (chrome://media-engagement/media-engagement.js:123:3)
at HTMLTableCellElement.headers.(anonymous function).addEventListener (chrome://media-engagement/media-engagement.js:173:7)
```
Version: 64.0.3278.0
,
Mar 20 2018
,
Mar 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d876c42b1c47372351a3706bf034f967417d7cb commit 5d876c42b1c47372351a3706bf034f967417d7cb Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Mar 21 14:46:13 2018 Media Engagement: Fix bug when sorting by isHigh Adds sort key handler for isHigh which will allow users to sort by "isHigh" when using chrome://media-engagement. BUG= 792906 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11db5ddf4843faca361eb9016535d582e6230fa5 Reviewed-on: https://chromium-review.googlesource.com/970584 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#544693} [modify] https://crrev.com/5d876c42b1c47372351a3706bf034f967417d7cb/chrome/browser/resources/media/media_engagement.js
,
Mar 21 2018
,
Mar 22 2018
Able to reproduce the issue on chrome reported version 64.0.3278.0 Verified the fix on Ubuntu 14.04 on Chrome version #67.0.3378.0 as per the comment#0 Attaching screen cast for reference. Observed "Updated sorted list and didn't observed any console error" Hence, the fix is working as expected. Adding the verified label. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by mlamouri@chromium.org
, Feb 8 2018