New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792903 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::ContainerNode::EnsurePreInsertionValidity

Project Member Reported by ClusterFuzz, Dec 7 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6245092213129216

Fuzzer: ifratric-browserfuzzer-v3
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::ContainerNode::EnsurePreInsertionValidity
  blink::ContainerNode::InsertBefore
  blink::ContainerNode::InsertBefore
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=521257:521271

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6245092213129216

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 7 2017

Components: Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 7 2017

Labels: Test-Predator-Auto-Owner
Owner: kochi@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/27fc5a3a1f3f1bdfa1e23602260c3d206b9ea79f (Remove AlwaysCreateUserAgentShadowRoot).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by ClusterFuzz, Dec 28 2017

Labels: OS-Windows

Comment 4 by kochi@chromium.org, Jan 5 2018

Labels: -Pri-1 OS-Android OS-Chrome OS-Linux Pri-2
Null-ptr deref, and technically it should reproduce on all Blink
platforms.

Comment 5 by kochi@chromium.org, Jan 5 2018

Labels: -Pri-2 Pri-1
Status: Started (was: Assigned)
Actually this is a regression.

Comment 6 by kochi@chromium.org, Jan 5 2018

Reverting the CL pointed out by comment#2.

With the change, the following HTML can create V0 shadow root
on <input> before its UA shadow root is attached.
```html
<input id="input_element" type="radio">
<script>
var root = input_element.createShadowRoot();
input_element.type = "text/vbs";
</script>
```

Revert CL:
https://chromium-review.googlesource.com/c/chromium/src/+/851852
Project Member

Comment 7 by ClusterFuzz, Jan 6 2018

ClusterFuzz has detected this issue as fixed in range 527241:527247.

Detailed report: https://clusterfuzz.com/testcase?key=6245092213129216

Fuzzer: ifratric-browserfuzzer-v3
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000010
Crash State:
  blink::ContainerNode::EnsurePreInsertionValidity
  blink::ContainerNode::InsertBefore
  blink::ContainerNode::InsertBefore
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=521257:521271
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=527241:527247

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6245092213129216

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jan 6 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6245092213129216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment