New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 792897 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Ctrl+a should select all entries on chrome://history

Project Member Reported by dullweber@chromium.org, Dec 7 2017

Issue description

Chrome Version: 63
OS: ChromeOS, Linux, probably the others as well

What steps will reproduce the problem?
(1) Go to chrome://history
(2) Search for something or click "More from this site" in the context menu of an entry
(3) Press ctrl+a

What is the expected result?
All entries should be selected

What happens instead?
Ctrl+a is not handled eplicitly, some text on the history page is selected.
Selecting all entries is quite complicated (select first, shift+click last)

 
This is problematic in an infinite list world. We don't actually have all the results, so we can't select all of them.

_However_, since the only thing you can do with history results is delete, them, we can probably get away with selecting all the visible history items, and having an 'All items selected' message or similar.

This might be nice to have, but the canonical way of clearing all your history is just to click Clear Browsing Data in the sidebar. Does this Ctrl + A functionality provide anything extra?
I tried to delete all items for a search. I think in this case it would be helpful to be able to remove everything visible. 
I agree that it is complicated if all history is displayed.
I just noticed that chrome://bookmarks already supports ctrl+a. What do you think about doing the same for chrome://history when there is a query and the list is finite?
Cc: tsergeant@chromium.org dpa...@chromium.org
Status: Available (was: Untriaged)
Bookmarks always has all its items.

It'll be confusing for the key to only work sometimes. I agree that it's useful to delete searches, but again, it's hard to do reliably with the infinite list. Maybe it's okay to just select all the rendered items. The search should refresh if we also move the list to the bottom, so it should be obvious to the user that more results have been loaded and they can mash ctrl+a again?
Hi. I'm interested with this issue. Can I work on this?
Yeah, go for it. I think my minimum standard for UX here is that 'if there are items that haven't been loaded yet, then the user should see that not all items will be/were deleted'.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67c8f89613bfaf24bf52f303dbec8267b52c7831

commit 67c8f89613bfaf24bf52f303dbec8267b52c7831
Author: sangwoo.ko <sangwoo108@gmail.com>
Date: Tue Jan 30 09:41:11 2018

Support ctrl+a at chrome://history

This shorcut will select or unselet all items.

Bug:  792897 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d0854c6e8bee90c947c741fc0ac4d14acd28e9d
Reviewed-on: https://chromium-review.googlesource.com/885692
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532822}
[modify] https://crrev.com/67c8f89613bfaf24bf52f303dbec8267b52c7831/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/67c8f89613bfaf24bf52f303dbec8267b52c7831/chrome/browser/resources/md_history/history.html
[modify] https://crrev.com/67c8f89613bfaf24bf52f303dbec8267b52c7831/chrome/browser/resources/md_history/history_list.js
[modify] https://crrev.com/67c8f89613bfaf24bf52f303dbec8267b52c7831/chrome/test/data/webui/md_history/history_list_test.js

Status: Fixed (was: Available)

Sign in to add a comment